Paths

Table of Contentst

Differential D8369

[desktop] add option to toggle shared worker dev dev-tools
ClosedPublic
Actions

Authored by kamil on Jun 29 2023, 6:12 AM.

Details

Reviewers

michal

Commits

rCOMM4a4c8d8879a1: [desktop] add option to toggle shared worker dev dev-tools

Summary

Helps debugging sqlite.

Test Plan

Check if button works

Diff Detail

Repository

rCOMM Comm

Branch

dev-tools

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 29 2023, 6:12 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 29 2023, 6:12 AM

Harbormaster completed remote builds in B20605: Diff 28253.Jun 29 2023, 6:29 AM

kamil published this revision for review.Jun 29 2023, 6:34 AM

I suspect this is going to throw an error if you close the window without closing the whole app (macOS-style) and run the new menu option. You could probably use the global mainWindow for inspectSharedWorker (with a check if it exists) instead.

desktop/src/main.js
65 ↗	(On Diff #28253)	We show the normal dev tools unconditionally, so I think we can also do that for release. It might help with debugging

use global mainWindow

Harbormaster completed remote builds in B20655: Diff 28309.Jun 30 2023, 9:40 AM

michal accepted this revision.Jul 3 2023, 4:23 AM

This revision is now accepted and ready to land.Jul 3 2023, 4:23 AM

Closed by commit rCOMM4a4c8d8879a1: [desktop] add option to toggle shared worker dev dev-tools (authored by kamil). · Explain WhyJul 3 2023, 8:22 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4a4c8d8879a1: [desktop] add option to toggle shared worker dev dev-tools.

Revision Contents
Changeset List

Path

Size

desktop/

flow-typed/

npm/

electron_v22.0.0.js

2 lines

src/

main.js

10 lines

Diff 28309

View Options

desktop/flow-typed/npm/electron_v22.0.0.js