[web] Keep modal width constant
ClosedPublic
Actions

Authored by tomek on Jul 12 2023, 1:59 AM.

Details

Reviewers

kamil
inka

Commits

rCOMM94248127be59: [web] Keep modal width constant

Summary

Change modal size to large so that it doesn't change. Also, introduce ellipsis when an invite link is too long (copy button copies the whole content).

https://linear.app/comm/issue/ENG-4375/invite-link-modal-on-web-changes-width-when-copy-button-is-pressed

Test Plan

Check if the modal has the same width even when a link is long and copy button is clicked.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jul 12 2023, 1:59 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 12 2023, 1:59 AM

tomek edited the summary of this revision. (Show Details)Jul 12 2023, 1:59 AM

tomek edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B20890: Diff 28612.Jul 12 2023, 2:17 AM

tomek requested review of this revision.Jul 12 2023, 2:17 AM

kamil accepted this revision.Jul 12 2023, 6:24 AM

This revision is now accepted and ready to land.Jul 12 2023, 6:24 AM

Closed by commit rCOMM94248127be59: [web] Keep modal width constant (authored by tomek). · Explain WhyJul 13 2023, 2:03 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM94248127be59: [web] Keep modal width constant.

Revision Contents
Changeset List

Path

Size

web/

invite-links/

copy-invite-link-button.css

2 lines

view-invite-link-modal.react.js

2 lines

Diff 28651

View Options

web/invite-links/copy-invite-link-button.css