[keyserver][web][native] Handle link creation / update errors
ClosedPublic
Actions

Authored by tomek on Jul 13 2023, 5:57 AM.

Details

Reviewers

kamil
inka
ashoat

Commits

rCOMM89ddf782aaf4: [keyserver][web][native] Handle link creation / update errors

Summary

In this diff we're handling two errors:

When invalid characters were used in the link

When an already used link was used

Copies are based on https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=11341%3A284796&mode=dev, but with some changes:

Replaced the first chars to the lowercase so that they are consistent e.g. with our login form.
Removed a set of invalid chars from invalid_characters error message because it is impossible to present a complete set of invalid chars (we only support [a-zA-Z0-9]).

https://linear.app/comm/issue/ENG-3916/better-error-handling

Test Plan

Check if a proper error message is displayed on both web and native when a user tries to:

create a link with ? as a secret
create a link with the same secret as some other link
update a link to have the same secret as some other link

Diff Detail

Repository

rCOMM Comm

Branch

invite-error

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jul 13 2023, 5:57 AM

tomek edited the summary of this revision. (Show Details)Jul 13 2023, 5:59 AM

Harbormaster completed remote builds in B20917: Diff 28671.Jul 13 2023, 6:15 AM

tomek requested review of this revision.Jul 13 2023, 6:15 AM

Let's actually capitalize the first letter. We should probably do the same in log-in form, but to be fair it's a little different visually... the errors there are shorter, and are not given their own full-width container (if I recall correctly)

ashoat added a subscriber: ashoat.Jul 13 2023, 6:25 AM

ashoat added inline comments.

keyserver/src/database/database.js
16	Current pattern for these is that they're defined next to callsite. Open to defining them all in `database.js`, but figure we should be consistent. Maybe you can submit a follow-up diff to update all locations to match your new convention?

kamil accepted this revision.Jul 17 2023, 5:14 AM

This revision is now accepted and ready to land.Jul 17 2023, 5:14 AM

tomek added a child revision: D8527: [keyserver] Handle offensive words in invite links.Jul 18 2023, 4:14 AM

tomek added a child revision: D8608: [keyserver] Extract database error codes.Jul 24 2023, 7:24 AM

Capitalize the first letters of error messages

In D8494#250498, @ashoat wrote:

Let's actually capitalize the first letter. We should probably do the same in log-in form, but to be fair it's a little different visually... the errors there are shorter, and are not given their own full-width container (if I recall correctly)

Yeah, the errors in login form are a lot shorter, so keeping them as they are also makes sense