Paths

Table of Contentst

Differential D8495

[lib] Don't send activity updates for pending threads
ClosedPublic
Actions

Authored by michal on Jul 13 2023, 5:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jun 19, 6:45 PM

	Unknown Object (File)
	Wed, Jun 19, 6:45 PM

	Unknown Object (File)
	Wed, Jun 19, 6:45 PM

	Unknown Object (File)
	Thu, Jun 13, 3:55 AM

	Unknown Object (File)
	Wed, Jun 12, 12:51 AM

	Unknown Object (File)
	Mon, Jun 10, 7:23 PM

	Unknown Object (File)
	May 17 2024, 5:27 PM

	Unknown Object (File)
	May 15 2024, 8:58 PM

View All 36 Files

Subscribers

Details

Reviewers

kamil
inka
tomek

Commits

rCOMM7436aaea94d4: [lib] Don't send activity updates for pending threads

Summary

After activating id migration, activityUpdateResponder started throwing errors, because the conversion logic didn't expect pending ids. This diff stops clients from sending updates for pending thread. They were already ignored by the keyserver anyway, so there should be no behaviour changes on the keyserver.

Test Plan

Create a new pending thread
- Without this diff there are invalid_client_id_prefix in the keyserver console. After this diff there are no error.
Checked that activity updates for other threads are still sent

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Jul 13 2023, 5:59 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 13 2023, 5:59 AM

Harbormaster completed remote builds in B20918: Diff 28672.Jul 13 2023, 6:16 AM

michal requested review of this revision.Jul 13 2023, 6:16 AM

Will this solve the problem for older clients? Or are older clients unaffected due to hasMinStateVersion checks?

EDIT – this was answered on Linear here

tomek accepted this revision.Jul 17 2023, 5:08 AM

This revision is now accepted and ready to land.Jul 17 2023, 5:08 AM

Closed by commit rCOMM7436aaea94d4: [lib] Don't send activity updates for pending threads (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJul 18 2023, 2:33 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM7436aaea94d4: [lib] Don't send activity updates for pending threads.

Revision Contents
Changeset List

Path

Size

lib/

socket/

activity-handler.react.js

12 lines

Diff 28767

lib/socket/activity-handler.react.js

Loading...