[keyserver][lib] Block users from creating reserved invite links
ClosedPublic
Actions

Authored by tomek on Jul 25 2023, 3:39 AM.

Details

Reviewers

kamil
inka
ashoat

Commits

rCOMM4ba08e6df607: [keyserver][lib] Block users from creating reserved invite links

Summary

A user should not be able to create a link which is included in a list of reserved usernames. The copy is similar to a message that is shown when a user tries to create an account with reserved username: /native/account/registration/registration-server-call.js, but I'm not sure if we should mention support email (the user is already registered and can contact us on Comm).

Depends on D8527

Test Plan

Try to create /comm invite link - a message should be displayed.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jul 25 2023, 3:39 AM

Harbormaster completed remote builds in B21178: Diff 29011.Jul 25 2023, 4:27 AM

tomek requested review of this revision.Jul 25 2023, 4:27 AM

inka accepted this revision.Jul 26 2023, 1:36 AM

This revision is now accepted and ready to land.Jul 26 2023, 1:36 AM

ashoat added inline comments.Jul 27 2023, 6:14 PM

lib/shared/invite-links.js
8–9 ↗	(On Diff #29011)	It's a little inconsistent how we're using full sentences here, but not in the other ones. Should we add a period to the other ones?