[keyserver] Use custom url on intermediate invite link page
ClosedPublic
Actions

Authored by tomek on Jul 25 2023, 5:22 AM.

Details

Reviewers

kamil
inka

Commits

rCOMM24b521e62f97: [keyserver] Use custom url on intermediate invite link page

Summary

Clicking universal links (https) in other browsers than Safari doesn't open the app. But using comm:// scheme should work correctly.

https://linear.app/comm/issue/ENG-4089/invite-links-dont-work-on-prod

Test Plan

Click a link (in Safari and Chrome) and check if the app is opened. It works in debug mode - still have to check in release.

Update: tested it in release mode and it works.

Diff Detail

Repository

rCOMM Comm

Branch

invite-error

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jul 25 2023, 5:22 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 25 2023, 5:22 AM

tomek edited the test plan for this revision. (Show Details)Jul 25 2023, 5:24 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2023, 6:16 AM

Harbormaster failed remote builds in B21183: Diff 29016!

Harbormaster completed remote builds in B21183: Diff 29016.Jul 26 2023, 1:21 AM

tomek requested review of this revision.Jul 26 2023, 1:21 AM

Why should it work correctly? There is no explanation and no issue linked (I'm guessing there is some explanation in the issue). This is hard to review without any explanation, and this is the only diff in the stack, so it's not even possible to search for answers there

tomek edited the summary of this revision. (Show Details)Jul 26 2023, 4:26 AM

tomek edited the summary of this revision. (Show Details)

In D8620#254184, @inka wrote:

Why should it work correctly? There is no explanation and no issue linked (I'm guessing there is some explanation in the issue). This is hard to review without any explanation, and this is the only diff in the stack, so it's not even possible to search for answers there

Sorry for that! Updated the summary with a link to Linear issue.

The context is included in https://linear.app/comm/issue/ENG-4089/invite-links-dont-work-on-prod task. Basically, for some reason, https:// scheme link opens in web browser after clicking in Chrome. I've tested https://linear.app/comm/issue/ENG-4089#comment-7015352a if the issue also appears for custom schemes, and fortunately, these work fine (clicking a link with custom scheme in Chrome opens the app).

kamil accepted this revision.Jul 27 2023, 7:50 AM

This revision is now accepted and ready to land.Jul 27 2023, 7:50 AM

tomek edited the test plan for this revision. (Show Details)Jul 31 2023, 5:14 AM

Closed by commit rCOMM24b521e62f97: [keyserver] Use custom url on intermediate invite link page (authored by tomek). · Explain WhyJul 31 2023, 5:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM24b521e62f97: [keyserver] Use custom url on intermediate invite link page.