Page MenuHomePhabricator
Differential D8649

[lib] Run conversion only on state check
ClosedPublic
Actions

Authored by michal on Jul 28 2023, 4:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 9:00 AM
Unknown Object (File)
Nov 20 2024, 5:40 PM
Unknown Object (File)
Nov 20 2024, 5:40 PM
Unknown Object (File)
Nov 20 2024, 5:40 PM
Unknown Object (File)
Nov 20 2024, 5:35 PM
Unknown Object (File)
Oct 22 2024, 2:30 PM
Unknown Object (File)
Oct 22 2024, 2:30 PM
Unknown Object (File)
Oct 22 2024, 2:29 PM
View All 54 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
ashoat
Commits
rCOMM9158eb67865b: [lib] Run conversion only on state check
Summary

ENG-4524
The id schema conversion for the state check was run everytime selector needed to be rerun, even when it wasn't necessary (e.g. navigating between threads). This diff changes it to so that the conversion is run only when the state check is requested from the keyserver.

Test Plan
  • Checked that the state check still runs correctly
  • Can't reproduce the performance problem on my machine (too small redux) but checked the performance graph in the browser when navigating between threads:

Before the changes:

image.png (1×1 px, 250 KB)

After the changes:
image.png (1×464 px, 195 KB)

You can see that the conversion doesn't run.

For comparison here's the graph for the current master:

image.png (1×1 px, 155 KB)

The highlighted Cn function is the id schema conversion function

Diff Detail

Repository
rCOMM Comm
Branch
micha/state-check-fix-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.Jul 28 2023, 4:03 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 28 2023, 4:03 AM
michal edited the test plan for this revision. (Show Details)Jul 28 2023, 4:09 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2023, 4:35 AM
Harbormaster failed remote builds in B21292: Diff 29160!
michal requested review of this revision.Jul 28 2023, 5:06 AM
ashoat accepted this revision.Jul 28 2023, 6:04 AM
This revision is now accepted and ready to land.Jul 28 2023, 6:04 AM
kamil accepted this revision.Jul 28 2023, 6:05 AM
This revision was landed with ongoing or failed builds.Jul 28 2023, 6:09 AM
Closed by commit rCOMM9158eb67865b: [lib] Run conversion only on state check (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM9158eb67865b: [lib] Run conversion only on state check.

Revision Contents
Changeset List

PathSize
lib/
selectors/
58 lines

Diff 29160

View Options

lib/selectors/socket-selectors.js

Loading...