Page MenuHomePhabricator

[desktop] Upgrade node-abi
ClosedPublic

Authored by michal on Jul 31 2023, 10:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 26, 7:39 PM
Unknown Object (File)
Wed, Jun 26, 10:59 AM
Unknown Object (File)
Tue, Jun 11, 1:29 PM
Unknown Object (File)
Mon, Jun 10, 7:24 PM
Unknown Object (File)
Apr 8 2024, 11:45 PM
Unknown Object (File)
Apr 8 2024, 11:45 PM
Unknown Object (File)
Apr 8 2024, 10:08 PM
Unknown Object (File)
Feb 20 2024, 2:07 PM
Subscribers

Details

Summary

ENG-4537

The version of the node-abi that we had in lockfile didn't have entries for the new electron versions. Upgrading it to this new version should help with the windows CI build failures (but I couldn't reproduce them myself so we will see). I've confirmed that the newest version has entries for electron v25.

I tried 3 ways to update the version:

  • yarn upgrade node-abi did nothing, probably because node-abi isn't a direct dependency
  • Following instructions from the main electron maintainer run npx uuaw node-abi which updated the lockfile to the version in this diff
  • Tried manually removing entries for node-abi from the lockfile and running yarn install which also ended in the lockfile version that's in this diff (matched the previous method)
Test Plan

yarn cleaninstall

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable