Page MenuHomePhabricator

Remove redundant warnings about notifications without message infos that exceed limits
ClosedPublic

Authored by marcin on Aug 1 2023, 6:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 9, 9:54 PM
Unknown Object (File)
Wed, May 8, 7:27 PM
Unknown Object (File)
Tue, May 7, 10:16 PM
Unknown Object (File)
Mon, May 6, 12:27 PM
Unknown Object (File)
Mon, May 6, 12:26 PM
Unknown Object (File)
Sat, May 4, 5:05 PM
Unknown Object (File)
Sat, May 4, 5:04 PM
Unknown Object (File)
Apr 8 2024, 5:11 AM
Subscribers

Details

Summary

this differential removes unecessary warnings. We don't have to check if notification exceeds FCM/APN size limits after messageInfos removal. The reason for this is that we construct notification body based on ResolvedNotifTexts, which trims
texts in notification: https://github.com/CommE2E/comm/blob/master/lib/shared/notif-utils.js#L50-L57.

Test Plan
  1. Build iOS and Android apps.
  2. Send large (more than 8000 characters) notification from web.
  3. Ensure that notification is displayed on both devices.
  4. Kill keyserver.
  5. Open both apps.
  6. Ensure notifications weren't persisted (since no messageInfos).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Rebase to update commit message

marcin requested review of this revision.Aug 1 2023, 8:10 AM
This revision is now accepted and ready to land.Aug 2 2023, 2:04 AM