Page MenuHomePhabricator
Differential D8602

Remove aes-crypto-utils.js from media and use common API to avoid redundent layer of abstraction
ClosedPublic
Actions

Authored by marcin on Jul 24 2023, 4:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 11:36 PM
Unknown Object (File)
Sat, Nov 23, 12:53 PM
Unknown Object (File)
Mon, Nov 11, 2:05 PM
Unknown Object (File)
Sun, Nov 10, 8:35 AM
Unknown Object (File)
Oct 16 2024, 8:50 AM
Unknown Object (File)
Oct 16 2024, 6:51 AM
Unknown Object (File)
Oct 13 2024, 4:33 AM
Unknown Object (File)
Oct 13 2024, 4:33 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMe6ba46a93134: Remove aes-crypto-utils.js from media and use common API to avoid redundent…
Summary

This differential removes web/media/aes-crypto-utils.js file and changes relevant files to make direct calls to lib/media/aes-crypto-utils.js API. This change was done in response to one of the comments to parent differential

Test Plan
  1. Run flow. 2. Ensure that CI passes (it runs jest)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jul 24 2023, 4:24 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2023, 4:24 AM
marcin updated this revision to Diff 28958.Jul 24 2023, 4:26 AM

Rebase to update commit message

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 24 2023, 4:39 AM
Harbormaster failed remote builds in B21136: Diff 28958!
Harbormaster completed remote builds in B21135: Diff 28957.Jul 24 2023, 4:41 AM
marcin added a parent revision: D8521: Enable webcrypto usage in keyserver codebase and unify aes crypto stack across web and the keyserver.Jul 24 2023, 4:45 AM
marcin added a child revision: D8529: Implement utility function on the keyserver to upload notification payload to blob service.
Harbormaster completed remote builds in B21136: Diff 28958.Jul 24 2023, 5:04 AM
marcin requested review of this revision.Jul 24 2023, 5:04 AM
bartek accepted this revision.Jul 25 2023, 3:05 AM
This revision is now accepted and ready to land.Jul 25 2023, 3:05 AM
marcin updated this revision to Diff 33416.Nov 20 2023, 5:42 AM

Rebase before landing

Harbormaster completed remote builds in B24278: Diff 33416.Nov 20 2023, 6:37 AM
Closed by commit rCOMMe6ba46a93134: Remove aes-crypto-utils.js from media and use common API to avoid redundent… (authored by marcin). · Explain WhyNov 20 2023, 7:09 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMe6ba46a93134: Remove aes-crypto-utils.js from media and use common API to avoid redundent….

Revision Contents
Changeset List

Diff 33429

View Options

web/account/qr-code-login.react.js

Loading...
View Options

web/media/aes-crypto-utils.js

Loading...
View Options

web/media/aes-crypto-utils.test.js

Loading...
View Options

web/media/encryption-utils.js

Loading...
View Options

web/media/image-utils.js

Loading...