Paths

Table of Contentst

[keyserver] await INSERT INTO messages before calling postMessageSend
ClosedPublic
Actions

Authored by ashoat on Aug 1 2023, 10:29 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 6, 4:59 AM

	Unknown Object (File)
	Thu, Jan 2, 11:28 AM

	Unknown Object (File)
	Thu, Jan 2, 11:28 AM

	Unknown Object (File)
	Thu, Jan 2, 11:28 AM

	Unknown Object (File)
	Thu, Jan 2, 11:23 AM

	Unknown Object (File)
	Sat, Dec 28, 5:38 PM

	Unknown Object (File)
	Nov 15 2024, 4:07 AM

	Unknown Object (File)
	Nov 15 2024, 2:58 AM

View All Files

Subscribers

None

Details

Reviewers

kamil
michal
atul
tomek

Commits

rCOMMf58ed7ac8353: [keyserver] await INSERT INTO messages before calling postMessageSend

Summary

We want to check if there is a collision on the INSERT before calling postMessageSend in order to avoid creating duplicate notifs or UpdateInfos.

See ENG-4563 for more details.

Test Plan

I tested message creation to make sure it still works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Aug 1 2023, 10:29 AM

Harbormaster completed remote builds in B21474: Diff 29453.Aug 1 2023, 11:34 AM

ashoat requested review of this revision.Aug 1 2023, 11:34 AM

atul accepted this revision.Aug 1 2023, 2:20 PM

This revision is now accepted and ready to land.Aug 1 2023, 2:20 PM

Closed by commit rCOMMf58ed7ac8353: [keyserver] await INSERT INTO messages before calling postMessageSend (authored by ashoat). · Explain WhyAug 1 2023, 5:57 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf58ed7ac8353: [keyserver] await INSERT INTO messages before calling postMessageSend.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

message-creator.js

3 lines

Diff 29469

View Options

keyserver/src/creators/message-creator.js

[keyserver] await INSERT INTO messages before calling postMessageSendClosedPublicActions