Page MenuHomePhabricator
Differential D8704

[keyserver, web] Remove baseHref field
ClosedPublic
Actions

Authored by inka on Aug 2 2023, 5:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 28, 10:16 AM
Unknown Object (File)
Wed, Jun 19, 9:23 AM
Unknown Object (File)
Wed, Jun 12, 9:12 PM
Unknown Object (File)
Thu, Jun 6, 12:59 AM
Unknown Object (File)
Thu, Jun 6, 12:59 AM
Unknown Object (File)
Wed, Jun 5, 11:59 PM
Unknown Object (File)
Jun 2 2024, 10:56 PM
Unknown Object (File)
May 7 2024, 10:17 PM
View All 51 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
Commits
rCOMMeb294510e780: [keyserver, web] Remove baseHref field
Summary

issue: https://linear.app/comm/issue/ENG-4214/review-basehref-filed-in-web-redux
baseHref field can be merged with urlPrefix. To see the full explanation see the discussion in the linked issue.

Test Plan

Checked that web still works - connects to the keyserver. Ran yarn flow-all

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
9 lines
web/
redux/
1 line
selectors/
2 lines

Diff 29879

View Options

keyserver/src/responders/website-responders.js

Loading...
View Options

web/redux/redux-setup.js

Loading...
View Options

web/selectors/socket-selectors.js

Loading...