Page MenuHomePhabricator
Differential D8724

[web] Introduce `useUploadAvatarMedia` to `AvatarHooks`
ClosedPublic
Actions

Authored by atul on Aug 3 2023, 11:48 PM.
Tags
None
Referenced Files
F2773712: D8724.diff
Fri, Sep 20, 2:42 AM
Unknown Object (File)
Tue, Sep 10, 3:21 AM
Unknown Object (File)
Fri, Sep 6, 7:31 PM
Unknown Object (File)
Wed, Aug 28, 8:59 AM
Unknown Object (File)
Wed, Aug 28, 8:59 AM
Unknown Object (File)
Wed, Aug 28, 8:59 AM
Unknown Object (File)
Wed, Aug 28, 8:58 AM
Unknown Object (File)
Aug 9 2024, 5:46 PM
View All 48 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMf86be566a289: [web] Introduce `useUploadAvatarMedia` to `AvatarHooks`
Summary

This function is similar to useUploadProcessedMedia() in native/avatar-hooks. It basically lets us upload the File we receive from image input.

We consume useUploadAvatarMedia in EditUserAvatarMenu to upload the selected image. In subsequent diffs, we will update onImageSelected to handle the setting of the image avatar as well.

Test Plan
  1. Select "Select image" from EditUserAvatarMenu
  2. Select an image from the file explorer
  3. Check the uploads table and observe that the image was uploaded:

086e26.png (1×3 px, 773 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Aug 3 2023, 11:48 PM
Herald added a subscriber: tomek. · View Herald TranscriptAug 3 2023, 11:48 PM
atul edited the test plan for this revision. (Show Details)Aug 3 2023, 11:57 PM
atul published this revision for review.Aug 4 2023, 12:54 AM
atul added inline comments.
web/avatars/edit-user-avatar-menu.react.js
72–73 ↗(On Diff #29524)

Error handling and whatnot will be handled later in the stack

Harbormaster completed remote builds in B21523: Diff 29524.Aug 4 2023, 1:01 AM
atul added a child revision: D8725: [web] Remove extraneous ESLint suppression.Aug 4 2023, 1:12 AM
ashoat accepted this revision.Aug 4 2023, 6:40 AM
This revision is now accepted and ready to land.Aug 4 2023, 6:40 AM
Closed by commit rCOMMf86be566a289: [web] Introduce `useUploadAvatarMedia` to `AvatarHooks` (authored by atul). · Explain WhyAug 4 2023, 2:41 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMf86be566a289: [web] Introduce `useUploadAvatarMedia` to `AvatarHooks`.

Revision Contents
Changeset List

PathSize
web/
avatars/
32 lines
6 lines

Diff 29555

View Options

web/avatars/avatar-hooks.react.js

Loading...
View Options

web/avatars/edit-user-avatar-menu.react.js

Loading...