issue: https://linear.app/comm/issue/ENG-4461/refactor-currentasof-field-in-message-store
currentAsOf is a timestamp. The client claims to have all messages that are interesting to it up until this point in time. It the socket needs to be re-initialiezed, it uses this value in the initial message to the server, to fetch
messages that came after. It is updated when the user logs in or recievies more messages. In the second case it is updated to the timestamp of the newest message the client has ever seen. So it makes sense to leave currentAsOf in
messageStore, because it is inferred from the value of messageStore when it updates.
Details
Details
Ran yarn flow-all. Tested that the migration on native works correctly. Checked that no errors are thrown from validators when web app is opened.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Accepting although I wonder how hard it would be to put this into the keyserverStore (during backup creation we want to save all keyserver-related information and now instead of having it all in one places it's split between two fields in redux)
Comment Actions
Accepting although I wonder how hard it would be to put this into the keyserverStore (during backup creation we want to save all keyserver-related information and now instead of having it all in one places it's split between two fields in redux)
Me, @michal and @kamil discussed this, and came to the conclusion that we shouldn't do this for now. And if we need it in the future, it won't be a big problem to change it