[lib] make calendarQuery field in SIWEAuthRequest type required
ClosedPublic
Actions

Authored by varun on Aug 4 2023, 6:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 26, 3:46 AM

	Unknown Object (File)
	Thu, Dec 26, 3:46 AM

	Unknown Object (File)
	Thu, Dec 26, 3:46 AM

	Unknown Object (File)
	Thu, Dec 26, 3:45 AM

	Unknown Object (File)
	Wed, Dec 18, 2:59 PM

	Unknown Object (File)
	Nov 25 2024, 3:02 PM

	Unknown Object (File)
	Nov 23 2024, 12:57 PM

	Unknown Object (File)
	Nov 23 2024, 12:57 PM

View All 90 Files

Subscribers

ashoat

tomek

Details

Reviewers

atul

Commits

rCOMM1a0820bdb68b: [lib] make calendarQuery field in SIWEAuthRequest type required

Summary

In siweAuthRequestInputValidator, calendarQuery is required, so the Flow type should match that.

Resolves https://linear.app/comm/issue/ENG-4581/make-calendarquery-required-in-siweauthrequest

Test Plan

ran flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 4 2023, 6:51 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 4 2023, 6:51 AM

Harbormaster completed remote builds in B21532: Diff 29539.Aug 4 2023, 7:10 AM

varun requested review of this revision.Aug 4 2023, 7:10 AM

atul accepted this revision.Aug 5 2023, 12:14 AM

This revision is now accepted and ready to land.Aug 5 2023, 12:14 AM

Closed by commit rCOMM1a0820bdb68b: [lib] make calendarQuery field in SIWEAuthRequest type required (authored by varun). · Explain WhyAug 10 2023, 6:36 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM1a0820bdb68b: [lib] make calendarQuery field in SIWEAuthRequest type required.

Revision Contents
Changeset List

Path

Size

lib/

types/

siwe-types.js

2 lines

Diff 29808

View Options

[lib] make calendarQuery field in SIWEAuthRequest type requiredClosedPublicActions