Differential D8729

[lib] make calendarQuery field in SIWEAuthRequest type required
ClosedPublic
Actions

Authored by varun on Aug 4 2023, 1:51 PM.

Details

Reviewers

atul

Commits

rCOMM1a0820bdb68b: [lib] make calendarQuery field in SIWEAuthRequest type required

Summary

In siweAuthRequestInputValidator, calendarQuery is required, so the Flow type should match that.

Resolves https://linear.app/comm/issue/ENG-4581/make-calendarquery-required-in-siweauthrequest

Test Plan

ran flow

Diff Detail

Repository

rCOMM Comm

Branch

new-responder (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 4 2023, 1:51 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 4 2023, 1:51 PM

Harbormaster completed remote builds in B21532: Diff 29539.Aug 4 2023, 2:10 PM

varun requested review of this revision.Aug 4 2023, 2:10 PM

atul accepted this revision.Aug 5 2023, 7:14 AM

This revision is now accepted and ready to land.Aug 5 2023, 7:14 AM

Closed by commit rCOMM1a0820bdb68b: [lib] make calendarQuery field in SIWEAuthRequest type required. · Explain WhyAug 10 2023, 1:36 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM1a0820bdb68b: [lib] make calendarQuery field in SIWEAuthRequest type required.

Revision Contents
Changeset List

Path

Size

lib/

types/

siwe-types.js

2 lines

Diff 29539

View Options

[lib] make calendarQuery field in SIWEAuthRequest type requiredClosedPublicActions