[native] Fix missing media mission report steps
ClosedPublic
Actions

Authored by bartek on Aug 5 2023, 5:25 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM89e87a98637a: [native] Fix missing media mission report steps

Summary

Some media mission steps were missing when encryption failed. It turns out that they weren't appended in the failure callback function. Added inline comments to explain the places.

Test Plan

Triggered encryption failure (write_file_failed) and confirmed that the steps were appended in the correct order.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 5 2023, 5:25 PM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptAug 5 2023, 5:25 PM

Harbormaster completed remote builds in B21547: Diff 29559.Aug 5 2023, 5:44 PM

bartek published this revision for review.Aug 5 2023, 5:56 PM

bartek added inline comments.

native/input/input-state-container.react.js
740–744	This is the failure case - `reportPromise` is non-null here. `encryptionSteps` don't need awaiting.
798–804	`encryptionSteps` are set here (L800) Right below the assignment we can see returning `onUploadFinished` failure callback, visible in above snippet (L736)
1038–1041	Successful case is handled here `reportPromise` is set to `null` so it isn't triggered again in `onUploadFinished`