[native] Fix cropped avatar selection
ClosedPublic
Actions

Authored by bartek on Aug 5 2023, 10:37 AM.

Details

Reviewers

atul
ashoat
ginsu

Commits

rCOMMa729baaeaa8f: [native] Fix cropped avatar selection

Summary

Fixes cropping part of ENG-4053.

Avoided replacing image URI with fetched asset URI when the file is in app's cache dir - this is where expo-image-picker stores cropped images.

Test Plan

Set cropped photo as an avatar - it is set correctly. Sent multimedia both with media gallery and image picker - both ways work. Checked both iOS and Android.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 5 2023, 10:37 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptAug 5 2023, 10:37 AM

Harbormaster completed remote builds in B21549: Diff 29561.Aug 5 2023, 10:55 AM

bartek published this revision for review.Aug 5 2023, 10:56 AM

bartek added inline comments.

native/media/file-utils.js
61 ↗	(On Diff #29561)	Decided to rename this variable - IMO it's more clear what it actually is
160 ↗	(On Diff #29561)	expo-image-picker uses a different cache directory than `react-native-fs` so needed to check this path separately