[keyserver] Add doNotRegister flag to siwe_auth endpoint
ClosedPublic
Actions

Authored by ashoat on Aug 7 2023, 12:48 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMM67f0fc6b4064: [keyserver] Add doNotRegister flag to siwe_auth endpoint

Summary

We need this optional flag so that we can prevent the web app from registering new accounts. See ENG-2930 for details.

Test Plan

Delete the Comm account for my test SIWE user
Patch web/account/siwe-login-form.react.js to include this flag
Confirm that it's now impossible to SIWE with my test SIWE user, and that the correct error is displayed in the console

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/siwe

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Aug 7 2023, 12:48 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 7 2023, 12:48 PM

Harbormaster completed remote builds in B21572: Diff 29596.Aug 7 2023, 1:07 PM

ashoat requested review of this revision.Aug 7 2023, 1:07 PM

ginsu accepted this revision.Aug 7 2023, 1:10 PM

This revision is now accepted and ready to land.Aug 7 2023, 1:10 PM

Closed by commit rCOMM67f0fc6b4064: [keyserver] Add doNotRegister flag to siwe_auth endpoint (authored by ashoat). · Explain WhyAug 8 2023, 5:47 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM67f0fc6b4064: [keyserver] Add doNotRegister flag to siwe_auth endpoint.

ashoat mentioned this in D10412: [native] Add support for doNotRegister to useSIWEServerCall.Dec 20 2023, 1:50 PM

ashoat mentioned this in rCOMMcb71eb7aa232: [native] Add support for doNotRegister to useSIWEServerCall.Dec 22 2023, 6:05 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

user-responders.js

6 lines

lib/

types/

siwe-types.js

1 line

Diff 29596

View Options

keyserver/src/responders/user-responders.js