[lib][native] Remove `displayFailureAlert` prop from `EditThreadAvatarProvider`
ClosedPublic
Actions

Authored by atul on Aug 8 2023, 1:40 AM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM752b499b6fa2: [lib][native] Remove `displayFailureAlert` prop from `EditThreadAvatarProvider`

Summary

As of D8757 we no longer need or use this prop. Surfacing of errors is handled by platform-specific code for consistency.

This is the thread avatar equivalent of D8342

Depends on D8757

Test Plan

NA/flow/eslint

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D8758 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Aug 8 2023, 1:40 AM

Herald added a subscriber: tomek. · View Herald TranscriptAug 8 2023, 1:40 AM

Harbormaster completed remote builds in B21585: Diff 29611.Aug 8 2023, 1:56 AM

atul requested review of this revision.Aug 8 2023, 1:57 AM

atul added a child revision: D8759: [lib] Rename `setThreadAvatar` to `baseSetThreadAvatar` in `EditThreadAvatarProvider`.Aug 8 2023, 2:01 AM

ashoat accepted this revision.Aug 8 2023, 7:13 AM

This revision is now accepted and ready to land.Aug 8 2023, 7:13 AM

rebase and land

This revision was landed with ongoing or failed builds.Aug 8 2023, 10:25 PM

Closed by commit rCOMM752b499b6fa2: [lib][native] Remove `displayFailureAlert` prop from `EditThreadAvatarProvider` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM752b499b6fa2: [lib][native] Remove `displayFailureAlert` prop from `EditThreadAvatarProvider`.

Harbormaster completed remote builds in B21668: Diff 29781.Aug 8 2023, 10:31 PM

Revision Contents
Changeset List

Path

Size

lib/

components/

base-edit-thread-avatar-provider.react.js

1 line

native/

avatars/

native-edit-thread-avatar-provider.react.js

10 lines

Diff 29781

View Options

lib/components/base-edit-thread-avatar-provider.react.js