Paths

Table of Contentst

[lib] Consolidate `updateImageThreadAvatar` into `baseSetThreadAvatar`
ClosedPublic
Actions

Authored by atul on Aug 9 2023, 3:21 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM4624708581d2: [lib] Consolidate `updateImageThreadAvatar` into `baseSetThreadAvatar`

Summary

This is the thread avatar version of D8363.

After removing all of the platform-specific stuff from updateImageThreadAvatar and baseSetThreadAvatar, there was one line different between them. Seemed simpler to handle w/ a conditional than two separate functions.

Test Plan

Close reading, made sure spinner continued to behave as expected when updating image avatar on native.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Aug 9 2023, 3:21 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 9 2023, 3:21 PM

atul published this revision for review.Aug 9 2023, 3:22 PM

Harbormaster completed remote builds in B21682: Diff 29801.Aug 9 2023, 3:41 PM

ashoat accepted this revision.Aug 9 2023, 4:57 PM

This revision is now accepted and ready to land.Aug 9 2023, 4:57 PM

rebase and land

This revision was landed with ongoing or failed builds.Aug 9 2023, 10:27 PM

Closed by commit rCOMM4624708581d2: [lib] Consolidate `updateImageThreadAvatar` into `baseSetThreadAvatar` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4624708581d2: [lib] Consolidate `updateImageThreadAvatar` into `baseSetThreadAvatar`.

Harbormaster completed remote builds in B21686: Diff 29805.Aug 9 2023, 10:40 PM

Revision Contents
Changeset List

Path

Size

lib/

components/

base-edit-thread-avatar-provider.react.js

47 lines

native/

avatars/

avatar-hooks.js

6 lines

Diff 29801

View Options

lib/components/base-edit-thread-avatar-provider.react.js