Page MenuHomePhabricator

[web/desktop] Make media overlay non-draggable
ClosedPublic

Authored by michal on Aug 17 2023, 6:42 AM.
Tags
None
Referenced Files
F2830095: D8848.id30067.diff
Fri, Sep 27, 6:50 PM
Unknown Object (File)
Fri, Sep 20, 7:16 AM
Unknown Object (File)
Fri, Sep 20, 7:16 AM
Unknown Object (File)
Fri, Sep 20, 7:16 AM
Unknown Object (File)
Fri, Sep 20, 12:34 AM
Unknown Object (File)
Mon, Sep 2, 3:52 PM
Unknown Object (File)
Aug 27 2024, 7:34 PM
Unknown Object (File)
Aug 27 2024, 11:22 AM
Subscribers

Details

Summary

ENG-4655

According to this issue, -webkit-app-region: drag (which is used for header dragging of the window) eats all events even for elements which defined outside of the header and just overlap with it.

The fix is to apply -webkit-app-region: no-drag to the multimedia overlay (we already apply it to the wordmark and navigation arrows).

Test Plan
  • Tested if clicking on the black overlay closed the image, both in inside header and outside
  • Tested if close button closed the overlay, and if the cursor pointer correctly changed when hovering
  • Tested if window wasn't draggable with overlay, and if it was draggable without overlay
  • Tested if navigation arrows still worked (without overlay)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable