[web] Fix nav info validator
ClosedPublic
Actions

Authored by michal on Aug 18 2023, 6:11 AM.

Details

Reviewers

ashoat
tomek
rohan

Commits

rCOMM54034056bcd6: [web] Fix nav info validator

Summary

ENG-4666
Validator wasn't updated to match the new type

Test Plan

Reloaded the web page in:

login screen
qr login screen (it was completely black, not sure if that's intended)
after logging in in chat view
in settings screen

There were no errors in keyserver console

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Aug 18 2023, 6:11 AM

michal added inline comments.Aug 18 2023, 6:13 AM

web/types/nav-types.js
17 ↗	(On Diff #30069)	Also moved this so it's next to the it's type

Thanks for putting up the fix!

qr login screen (it was completely black, not sure if that's intended)

Yeah it's intended until D8821 is landed to put content on the page

Harbormaster completed remote builds in B21889: Diff 30069.Aug 18 2023, 6:29 AM

michal requested review of this revision.Aug 18 2023, 6:29 AM

rohan accepted this revision.Aug 18 2023, 6:30 AM

This revision is now accepted and ready to land.Aug 18 2023, 6:30 AM

Closed by commit rCOMM54034056bcd6: [web] Fix nav info validator (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 18 2023, 6:36 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM54034056bcd6: [web] Fix nav info validator.

Revision Contents
Changeset List

Path

Size

web/

types/

nav-types.js

4 lines

Diff 30071

View Options

[web] Fix nav info validatorClosedPublicActions