Page MenuHomePhabricator

[lib/native] Remain consistent with url naming pattern

Authored by rohan on Fri, Sep 8, 7:52 AM.
Referenced Files
Unknown Object (File)
Sat, Sep 16, 6:08 PM
Unknown Object (File)
Fri, Sep 15, 11:24 AM



Quick follow up for this comment. Though we no longer use parseKeysFromQRCodeURL, we have parseInstallReferrerFromInviteLinkURL. I decided to
match the convention with inviteLinkUrl and qrCodeLinkUrl, so I've renamed parseInstallReferrerFromInviteLinkURL to parseInstallReferrerFromInviteLinkUrl.

Test Plan

Ran flow and confirmed no errors

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

rohan requested review of this revision.Fri, Sep 8, 8:10 AM
This revision is now accepted and ready to land.Fri, Sep 8, 8:57 AM
ginsu requested changes to this revision.Fri, Sep 8, 9:01 AM

actually after doing a quick global search it seems like the pattern is to have url be "URL" (it's not perfect throughout the codebase, but seems like the majority of cases go with all caps) . Could we make inviteLinkUrl => inviteLinkURL and qrCodeLinkUrl => qrCodeLinkURL

This revision now requires changes to proceed.Fri, Sep 8, 9:01 AM

Rename all instances of '...Url' with '...URL'

This revision is now accepted and ready to land.Fri, Sep 8, 5:47 PM