Paths

Table of Contentst

Differential D9118

[native] Convert `ConnectedSwipeable` to functional component
ClosedPublic
Actions

Authored by atul on Sep 10 2023, 5:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 29, 10:13 AM

	Unknown Object (File)
	Mon, Oct 28, 1:00 PM

	Unknown Object (File)
	Tue, Oct 22, 2:18 PM

	Unknown Object (File)
	Tue, Oct 22, 2:18 PM

	Unknown Object (File)
	Tue, Oct 22, 2:18 PM

	Unknown Object (File)
	Tue, Oct 22, 2:17 PM

	Unknown Object (File)
	Tue, Oct 22, 5:04 AM

	Unknown Object (File)
	Sun, Oct 6, 4:51 PM

View All 58 Files

Subscribers

Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMMac54b888a06d: [native] Convert `ConnectedSwipeable` to functional component

Summary

I thought the changes here would prevent SwipeableThread from re-rendering, but it looks like I misinterpreted some profiling sessions... that said I already did this work so figured I'd put it up (assuming it isn't burdensome for reviewers to review, etc.)

Test Plan

SwipeableThread continues to look and work as before.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Sep 10 2023, 5:52 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 10 2023, 5:52 PM

Harbormaster completed remote builds in B22477: Diff 30908.Sep 10 2023, 6:11 PM

atul requested review of this revision.Sep 10 2023, 6:11 PM

tomek accepted this revision.Sep 11 2023, 4:19 AM

tomek added inline comments.

native/components/swipeable.js
109 ↗	(On Diff #30908)	Is it intentional to drop `React.memo`?

This revision is now accepted and ready to land.Sep 11 2023, 4:19 AM

atul added inline comments.Sep 11 2023, 10:50 AM

native/components/swipeable.js
109 ↗	(On Diff #30908)	We're still memoizing Swipeable just w/ `React.useMemo` instead of `React.Memo`

atul attached a referenced file: F753200: 572e23.png. (Show Details)Sep 11 2023, 10:50 AM

rebase and land

This revision was landed with ongoing or failed builds.Sep 11 2023, 10:52 AM

Closed by commit rCOMMac54b888a06d: [native] Convert `ConnectedSwipeable` to functional component (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMac54b888a06d: [native] Convert `ConnectedSwipeable` to functional component.

Harbormaster completed remote builds in B22502: Diff 30935.Sep 11 2023, 11:10 AM

Revision Contents
Changeset List

Path

Size

native/

components/

138 lines

Diff 30936

native/components/swipeable.js

Loading...