Details

Reviewers

bartek
atul

Commits

rCOMMf1a8c5ad6000: [native] Use blobServiceUpload upload action

Summary

This diff uses new blobServiceUpload upload action in input-state-container.

Depends on D9157.

Test Plan

Check if upload behavior hasn't changed.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Sep 12 2023, 9:00 PM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 9:00 PM

Harbormaster failed remote builds in B22551: Diff 30997!Sep 12 2023, 9:23 PM

• patryk edited the summary of this revision. (Show Details)Sep 13 2023, 9:49 AM

• patryk edited the test plan for this revision. (Show Details)

• patryk added a parent revision: D9157: [lib] Add blobServiceUpload upload action.

• patryk published this revision for review.Sep 14 2023, 11:46 AM

bartek accepted this revision.Sep 18 2023, 11:55 AM

bartek added inline comments.

native/utils/blob-service-upload.js
36 ↗	(On Diff #30997)
42 ↗	(On Diff #30997)	Perhaps we can use the newer syntax here

This revision is now accepted and ready to land.Sep 18 2023, 11:55 AM

Use new syntax

Harbormaster failed remote builds in B22671: Diff 31198!Sep 18 2023, 12:45 PM

Rebuild

Harbormaster failed remote builds in B22675: Diff 31202!Sep 18 2023, 2:37 PM

Fix flow bugs

Harbormaster completed remote builds in B22677: Diff 31204.Sep 18 2023, 3:02 PM

Closed by commit rCOMMf1a8c5ad6000: [native] Use blobServiceUpload upload action. · Explain WhySep 28 2023, 7:56 AM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMMf1a8c5ad6000: [native] Use blobServiceUpload upload action.

[native] Use blobServiceUpload upload action
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31482

native/input/input-state-container.react.js

native/utils/blob-service-upload.js

[native] Use blobServiceUpload upload actionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31482

native/input/input-state-container.react.js

native/utils/blob-service-upload.js

[native] Use blobServiceUpload upload action
ClosedPublic
Actions

Revision Contents
Changeset List