Paths

Table of Contentst

-
keyserver/src/shared/state-sync/
-
src/
-
shared/
-
state-sync/
1/1
state-sync-specs.js
-
lib/shared/state-sync/
-
shared/
-
state-sync/
1/1
state-sync-specs.js

[lib/keyserver] Improve state sync types
ClosedPublic
Actions

Authored by michal on Sep 21 2023, 3:49 AM.

Details

Reviewers

inka
tomek

Commits

rCOMM9c57379d7a7e: [lib/keyserver] Improve state sync types

Summary

ENG-4909

We can keep the very specific types for specs collections that flow gives us, while adding an assert to make sure we don't pass anything that is not a spec to these object. Also replaced * -> any, as they are aliases and * is deprecated.

Test Plan

yarn flow-all

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Sep 21 2023, 3:49 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 21 2023, 3:49 AM

Harbormaster completed remote builds in B22772: Diff 31331.Sep 21 2023, 4:08 AM

michal requested review of this revision.Sep 21 2023, 4:08 AM

tomek accepted this revision.Sep 22 2023, 3:24 AM

This revision is now accepted and ready to land.Sep 22 2023, 3:24 AM

michal added a child revision: D9266: [lib/keyserver] Make Info generic mandatory in state sync specs.Sep 22 2023, 3:48 AM

Closed by commit rCOMM9c57379d7a7e: [lib/keyserver] Improve state sync types (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 29 2023, 2:59 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM9c57379d7a7e: [lib/keyserver] Improve state sync types.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

shared/

state-sync/

state-sync-specs.js

8 lines

lib/

shared/

state-sync/

state-sync-specs.js

8 lines

Diff 31331

View Options

keyserver/src/shared/state-sync/state-sync-specs.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };