Page MenuHomePhabricator
Differential D9264

[keyserver] use correct key for device ID
ClosedPublic
Actions

Authored by varun on Sep 22 2023, 12:00 AM.
Tags
None
Referenced Files
F5941438: D9264.id31362.diff
Fri, Apr 18, 8:06 AM
F5915073: D9264.id31373.diff
Thu, Apr 17, 8:39 PM
F5911428: D9264.id31373.diff
Thu, Apr 17, 5:39 PM
F5911427: D9264.id31362.diff
Thu, Apr 17, 5:39 PM
F5911426: D9264.id.diff
Thu, Apr 17, 5:39 PM
Unknown Object (File)
Thu, Apr 17, 4:52 AM
Unknown Object (File)
Mar 11 2025, 11:10 PM
Unknown Object (File)
Mar 11 2025, 10:39 AM
View All 100 Files
Subscribers
ashoat
tomek

Details

Reviewers
rohan
Commits
rCOMM2b0757b8e34b: [keyserver] use correct key for device ID
Summary

resolves: https://linear.app/comm/issue/ENG-4993/use-correct-key-content-ed25519-public-key-as-device-id

Depends on D9220

Test Plan

just tested with flow. it's a pretty straightforward refactor

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Sep 22 2023, 12:00 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 22 2023, 12:00 AM
Harbormaster completed remote builds in B22796: Diff 31362.Sep 22 2023, 12:18 AM
varun requested review of this revision.Sep 22 2023, 12:18 AM
rohan accepted this revision.Sep 22 2023, 7:31 AM
This revision is now accepted and ready to land.Sep 22 2023, 7:31 AM
rohan added a comment.Sep 22 2023, 7:35 AM

Sorry, could you actually rebase and use the renamed function getContentSigningKey (I just updated D9220)?

Closed by commit rCOMM2b0757b8e34b: [keyserver] use correct key for device ID (authored by varun). · Explain WhySep 22 2023, 8:21 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM2b0757b8e34b: [keyserver] use correct key for device ID.

Revision Contents
Changeset List

PathSize
keyserver/
src/
utils/
4 lines

Diff 31373

View Options

keyserver/src/utils/olm-utils.js

Loading...