See this comment
Details
Details
yarn cleaninstall:
$ /Users/ashoat/src/comm/node_modules/.bin/patch-package patch-package 6.4.7 Applying patches... @expo/cli@0.4.11 ✔ @rainbow-me/rainbowkit@0.12.15 ✔ @react-native-clipboard/clipboard@1.11.1 ✔ hazel-server@5.1.1 ✔ olm@3.2.4 ✔ react-native@0.70.9 ✔ react-native-camera@3.31.0 ✔ react-native-ffmpeg@0.4.4 ✔ react-native-in-app-message@1.0.2 ✔ react-native-keyboard-input@6.0.1 ✔ react-native-orientation-locker@1.5.0 ✔ react-native-video@5.2.1 ✔ redux-persist@6.0.0 ✔ remote-redux-devtools@0.5.16 ✔ remotedev@0.2.9 ✔
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
So I actually tried to include this in D9227: https://phab.comm.dev/D9227?vs=on&id=31269#toc, but there was some additional stuff that got included when I ran patch package (figured that was safer than just renaming file)
Was holding off on landing that diff until A. "Can you create a GitHub issue on the Expo repo and link it here before landing?" and B. trying to get rid of that (seemingly extraneous?) "hunk."
Looks like patch in this diff applies fine and CI continues to pass, so seems good to go?