Page MenuHomePhabricator
Differential D9227

[patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma
AcceptedPublic
Actions

Authored by atul on Tue, Sep 19, 9:57 AM.

Details

Reviewers
ashoat
ginsu
tomek
rohan
bartek
Summary

Context: https://linear.app/comm/issue/ENG-4984/xcode-version-15-update

Test Plan

No longer encountering the Foundation import issue after yarn cleaninstall

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Tue, Sep 19, 9:57 AM
atul edited the summary of this revision. (Show Details)Tue, Sep 19, 9:58 AM
atul updated this revision to Diff 31270.Tue, Sep 19, 10:00 AM

fix

atul published this revision for review.Tue, Sep 19, 10:00 AM
atul added a child revision: D9228: [iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock iOS build.Tue, Sep 19, 10:12 AM
Harbormaster completed remote builds in B22731: Diff 31269.Tue, Sep 19, 10:15 AM
Harbormaster completed remote builds in B22732: Diff 31270.Tue, Sep 19, 10:25 AM
ashoat added a comment.Tue, Sep 19, 10:43 AM

Is there a GitHub issue in Expo's GitHub repo for this?

atul added a comment.Wed, Sep 20, 9:47 AM
In D9227#271710, @ashoat wrote:

Is there a GitHub issue in Expo's GitHub repo for this?

Not that I'm seeing. I think it might have to do with how we're importing some Expo library/some C++ target version setting specific to our project?

ashoat accepted this revision.Wed, Sep 20, 10:36 AM

Can you create a GitHub issue on the Expo repo and link it here before landing?

This revision is now accepted and ready to land.Wed, Sep 20, 10:36 AM
atul added a comment.Wed, Sep 20, 10:39 AM
In D9227#272137, @ashoat wrote:

Can you create a GitHub issue on the Expo repo and link it here before landing?

Yeah I can make a GitHub issue before landing. I'm fairly sure this is something specific to our codebase so I'll try to do a little more investigation before submitting an issue.

atul updated this revision to Diff 31347.Thu, Sep 21, 10:55 AM

rebase

Harbormaster completed remote builds in B22784: Diff 31347.Thu, Sep 21, 11:13 AM

Revision Contents
Changeset List

PathSize
patches/
21 lines

Diff 31347

View Options

patches/expo-modules-core+1.1.1.patch

Loading...