Page MenuHomePhabricator
Differential D9228

[iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock iOS build
ClosedPublic
Actions

Authored by atul on Sep 19 2023, 10:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 10:02 PM
Unknown Object (File)
Mar 3 2025, 10:11 AM
Unknown Object (File)
Feb 25 2025, 8:55 PM
Unknown Object (File)
Feb 15 2025, 7:56 PM
Unknown Object (File)
Feb 15 2025, 4:41 AM
Unknown Object (File)
Feb 2 2025, 6:21 PM
Unknown Object (File)
Jan 31 2025, 8:48 AM
Unknown Object (File)
Jan 31 2025, 8:48 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
bartek
Commits
rCOMMf30690b547dd: [iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock…
Summary

Linear: https://linear.app/comm/issue/ENG-4984/xcode-version-15-update
GitHub: https://github.com/facebook/react-native/issues/37748

Depends on D9227

Test Plan

iOS builds succeeds after yarn cleaninstall without issue.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
ios/
3 lines
2 lines

Diff 31287

View Options

native/ios/Podfile

Show All 30 Lines): Promise<FetchServerThreadInfosResult> {
const rolesQuery = SQL` const rolesQuery = SQL`
SELECT t.id, t.default_role, r.id AS role, r.name, r.permissions SELECT t.id, t.default_role, r.id AS role, r.name, r.permissions
FROM threads t FROM threads t
LEFT JOIN roles r ON r.thread = t.id LEFT JOIN roles r ON r.thread = t.id
`.append(whereClause); `.append(whereClause);
const threadsQuery = SQL` const threadsQuery = SQL`
SELECT t.id, t.name, t.parent_thread_id, t.containing_thread_id, SELECT t.id, t.name, t.parent_thread_id, t.containing_thread_id,
t.community, t.depth, t.color, t.description, t.type, t.creation_time, t.community, t.depth, t.color, t.description, t.type, t.creation_time,
t.source_message, t.replies_count, t.avatar, m.user, m.role, m.permissions, t.source_message, t.replies_count, t.avatar, t.pinned_count, m.user,
m.subscription, m.last_read_message < m.last_message AS unread, m.sender m.role, m.permissions, m.subscription,
m.last_read_message < m.last_message AS unread, m.sender
FROM threads t FROM threads t
LEFT JOIN memberships m ON m.thread = t.id AND m.role >= 0 LEFT JOIN memberships m ON m.thread = t.id AND m.role >= 0
` `
.append(whereClause) .append(whereClause)
.append(SQL` ORDER BY m.user ASC`); .append(SQL` ORDER BY m.user ASC`);
const [[threadsResult], [rolesResult]] = await Promise.all([ const [[threadsResult], [rolesResult]] = await Promise.all([
dbQuery(threadsQuery), dbQuery(threadsQuery),
dbQuery(rolesQuery), dbQuery(rolesQuery),
]); ]);
Show All 16 Lines if (!threadInfos[threadID]) {
: null, : null,
depth: threadsRow.depth, depth: threadsRow.depth,
community: threadsRow.community community: threadsRow.community
? threadsRow.community.toString() ? threadsRow.community.toString()
: null, : null,
members: [], members: [],
roles: {}, roles: {},
repliesCount: threadsRow.replies_count, repliesCount: threadsRow.replies_count,
pinnedCount: threadsRow.pinned_count,
}; };
if (threadsRow.avatar) { if (threadsRow.avatar) {
threadInfos[threadID] = { threadInfos[threadID] = {
...threadInfos[threadID], ...threadInfos[threadID],
avatar: JSON.parse(threadsRow.avatar), avatar: JSON.parse(threadsRow.avatar),
}; };
} }
} }
▲ Show 20 Lines • Show All 75 Lines • ▼ Show 20 Lines const hasCodeVersionBelow104 = !hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
104, 104,
); );
// TODO (atul): Replace with `hasMinCodeVersion` check once we have a // TODO (atul): Replace with `hasMinCodeVersion` check once we have a
// native release with thread avatar editing enabled. // native release with thread avatar editing enabled.
const filterThreadEditAvatarPermission = true; const filterThreadEditAvatarPermission = true;
const hasCodeVersionBelow209 = !hasMinCodeVersion(
viewer.platformDetails,
209,
);
const threadInfos = {}; const threadInfos = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
includeVisibilityRules: hasCodeVersionBelow70, includeVisibilityRules: hasCodeVersionBelow70,
filterMemberList: hasCodeVersionBelow70, filterMemberList: hasCodeVersionBelow70,
shimThreadTypes: hasCodeVersionBelow87 ? shimCommunityRoot : null, shimThreadTypes: hasCodeVersionBelow87 ? shimCommunityRoot : null,
hideThreadStructure: hasCodeVersionBelow102, hideThreadStructure: hasCodeVersionBelow102,
filterDetailedThreadEditPermissions: hasCodeVersionBelow104, filterDetailedThreadEditPermissions: hasCodeVersionBelow104,
filterThreadEditAvatarPermission, filterThreadEditAvatarPermission,
excludePinInfo: hasCodeVersionBelow209,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines
View Options

native/ios/Podfile.lock

Show All 30 Lines): Promise<FetchServerThreadInfosResult> {
const rolesQuery = SQL` const rolesQuery = SQL`
SELECT t.id, t.default_role, r.id AS role, r.name, r.permissions SELECT t.id, t.default_role, r.id AS role, r.name, r.permissions
FROM threads t FROM threads t
LEFT JOIN roles r ON r.thread = t.id LEFT JOIN roles r ON r.thread = t.id
`.append(whereClause); `.append(whereClause);
const threadsQuery = SQL` const threadsQuery = SQL`
SELECT t.id, t.name, t.parent_thread_id, t.containing_thread_id, SELECT t.id, t.name, t.parent_thread_id, t.containing_thread_id,
t.community, t.depth, t.color, t.description, t.type, t.creation_time, t.community, t.depth, t.color, t.description, t.type, t.creation_time,
t.source_message, t.replies_count, t.avatar, m.user, m.role, m.permissions, t.source_message, t.replies_count, t.avatar, t.pinned_count, m.user,
m.subscription, m.last_read_message < m.last_message AS unread, m.sender m.role, m.permissions, m.subscription,
m.last_read_message < m.last_message AS unread, m.sender
FROM threads t FROM threads t
LEFT JOIN memberships m ON m.thread = t.id AND m.role >= 0 LEFT JOIN memberships m ON m.thread = t.id AND m.role >= 0
` `
.append(whereClause) .append(whereClause)
.append(SQL` ORDER BY m.user ASC`); .append(SQL` ORDER BY m.user ASC`);
const [[threadsResult], [rolesResult]] = await Promise.all([ const [[threadsResult], [rolesResult]] = await Promise.all([
dbQuery(threadsQuery), dbQuery(threadsQuery),
dbQuery(rolesQuery), dbQuery(rolesQuery),
]); ]);
Show All 16 Lines if (!threadInfos[threadID]) {
: null, : null,
depth: threadsRow.depth, depth: threadsRow.depth,
community: threadsRow.community community: threadsRow.community
? threadsRow.community.toString() ? threadsRow.community.toString()
: null, : null,
members: [], members: [],
roles: {}, roles: {},
repliesCount: threadsRow.replies_count, repliesCount: threadsRow.replies_count,
pinnedCount: threadsRow.pinned_count,
}; };
if (threadsRow.avatar) { if (threadsRow.avatar) {
threadInfos[threadID] = { threadInfos[threadID] = {
...threadInfos[threadID], ...threadInfos[threadID],
avatar: JSON.parse(threadsRow.avatar), avatar: JSON.parse(threadsRow.avatar),
}; };
} }
} }
▲ Show 20 Lines • Show All 75 Lines • ▼ Show 20 Lines const hasCodeVersionBelow104 = !hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
104, 104,
); );
// TODO (atul): Replace with `hasMinCodeVersion` check once we have a // TODO (atul): Replace with `hasMinCodeVersion` check once we have a
// native release with thread avatar editing enabled. // native release with thread avatar editing enabled.
const filterThreadEditAvatarPermission = true; const filterThreadEditAvatarPermission = true;
const hasCodeVersionBelow209 = !hasMinCodeVersion(
viewer.platformDetails,
209,
);
const threadInfos = {}; const threadInfos = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
includeVisibilityRules: hasCodeVersionBelow70, includeVisibilityRules: hasCodeVersionBelow70,
filterMemberList: hasCodeVersionBelow70, filterMemberList: hasCodeVersionBelow70,
shimThreadTypes: hasCodeVersionBelow87 ? shimCommunityRoot : null, shimThreadTypes: hasCodeVersionBelow87 ? shimCommunityRoot : null,
hideThreadStructure: hasCodeVersionBelow102, hideThreadStructure: hasCodeVersionBelow102,
filterDetailedThreadEditPermissions: hasCodeVersionBelow104, filterDetailedThreadEditPermissions: hasCodeVersionBelow104,
filterThreadEditAvatarPermission, filterThreadEditAvatarPermission,
excludePinInfo: hasCodeVersionBelow209,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines