Page MenuHomePhabricator
Differential D9228

[iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock iOS build
ClosedPublic
Actions

Authored by atul on Sep 19 2023, 10:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 10:02 PM
Unknown Object (File)
Mar 3 2025, 10:11 AM
Unknown Object (File)
Feb 25 2025, 8:55 PM
Unknown Object (File)
Feb 15 2025, 7:56 PM
Unknown Object (File)
Feb 15 2025, 4:41 AM
Unknown Object (File)
Feb 2 2025, 6:21 PM
Unknown Object (File)
Jan 31 2025, 8:48 AM
Unknown Object (File)
Jan 31 2025, 8:48 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
bartek
Commits
rCOMMf30690b547dd: [iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock…
Summary

Linear: https://linear.app/comm/issue/ENG-4984/xcode-version-15-update
GitHub: https://github.com/facebook/react-native/issues/37748

Depends on D9227

Test Plan

iOS builds succeeds after yarn cleaninstall without issue.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
ios/
3 lines
2 lines

Diff 31287

View Options

native/ios/Podfile

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
jsi::Value getUserPublicKey(jsi::Runtime &rt) override; jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override; jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
jsi::Object jsi::Object
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
void clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

native/ios/Podfile.lock

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
jsi::Value getUserPublicKey(jsi::Runtime &rt) override; jsi::Value getUserPublicKey(jsi::Runtime &rt) override;
jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override; jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;
jsi::Object jsi::Object
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
void clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm