adding/updating types for the keyserver and native/web to consume later in the stack
Details
Details
- Reviewers
ashoat
just flow for this diff. tested more thoroughly when the types are used later in stack.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Accepting to unblock, but I have some questions and nits
| lib/actions/identity-service-auth-actions.js | ||
|---|---|---|
| 26 | What’s the reason we need custom options? It often helps to introduce the first usage of a new function alongside that function | |
| lib/types/account-types.js | ||
| 165 | Should these be read-only? | |
| 184 | Naming nit: this appears to be the “input” rather than the server call. I would expect a type named “SomethingServerCall” to be eg. returned by useServerCall | |
| 186 | Is it worth clarifying content vs. notif keys? What’s our “best practice” on naming these? | |
| lib/types/endpoints.js | ||
| 104 | Usually we introduce these when the endpoint is introduced, and usually the endpoint is introduced before the usage is. Can you link the diff for the endpoint or is it not up yet? | |