Page MenuHomePhabricator

[keyserver] refactor olm session creator
AbandonedPublic

Authored by varun on Oct 2 2023, 7:47 PM.
Tags
None
Referenced Files
F2193283: D9345.id31601.diff
Thu, Jul 4, 9:34 PM
Unknown Object (File)
Tue, Jul 2, 9:39 PM
Unknown Object (File)
Tue, Jul 2, 9:39 PM
Unknown Object (File)
Tue, Jul 2, 9:36 PM
Unknown Object (File)
Fri, Jun 28, 8:21 AM
Unknown Object (File)
Tue, Jun 25, 6:51 AM
Unknown Object (File)
Wed, Jun 12, 4:06 PM
Unknown Object (File)
Jun 2 2024, 6:50 PM
Subscribers

Details

Reviewers
marcin
Summary

we need separate functions for creating and storing olm sessions because we may not know the cookie ID at creation time

Depends on D9334

Test Plan

registered a new device on the keyserver and confirmed the notif olm session was stored in my mariadb instance

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Oct 2 2023, 8:05 PM

@marcin should be back tomorrow, but might need some time to catch up on things... might be good to add another reviewer to this

we need separate functions for creating and storing olm sessions because we may not know the cookie ID at creation time

What is the example of such situation?

registered a new device on the keyserver and confirmed the notif olm session was stored in my mariadb instance

This should test that createAndStoreOlmSession works properly. How would you test that separate methods to create and store session work properly? Perhaps you should execute a scenario when session is needed before we have cookieID?