Page MenuHomePhabricator
Differential D9548

[keyserver] Replace extendCookieLifespan with updateCookie
ClosedPublic
Actions

Authored by ashoat on Oct 19 2023, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 5, 2:08 AM
Unknown Object (File)
Feb 16 2025, 6:31 PM
Unknown Object (File)
Feb 16 2025, 6:31 PM
Unknown Object (File)
Feb 16 2025, 6:31 PM
Unknown Object (File)
Feb 16 2025, 6:27 PM
Unknown Object (File)
Feb 1 2025, 8:52 AM
Unknown Object (File)
Jan 14 2025, 8:00 AM
Unknown Object (File)
Jan 5 2025, 8:36 PM
View All 79 Files
Subscribers
will

Details

Reviewers
atul
tomek
Commits
rCOMM397b4542fa7b: [keyserver] Replace extendCookieLifespan with updateCookie
Summary

In the next diff this function will be used to replace a bcrypt hash with a sha256 one. I want to do that in this function to avoid introducing any new SQL queries. extendCookieLifespan already runs very frequently, so it's a good place to make this change to ensure that we quickly migrate to sha256 hashes.

Ahead of that change, this diff renames the function and updates it to take a full Viewer parameter.

Depends on D9546

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
session/
9 lines
socket/
4 lines

Diff 32263

View Options

keyserver/src/session/cookies.js

use clap::{Parser, Subcommand};
use tonic::transport::Server; use tonic::transport::Server;
mod keygen;
mod opaque;
mod service; mod service;
use keygen::generate_and_persist_keypair;
use service::{IdentityServiceServer, MyIdentityService}; use service::{IdentityServiceServer, MyIdentityService};
const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051"; const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051";
const DEFAULT_SECRETS_DIRECTORY: &str = "secrets";
#[derive(Parser)]
#[clap(author, version, about, long_about = None)]
#[clap(propagate_version = true)]
struct Cli {
#[clap(subcommand)]
command: Commands,
}
#[derive(Subcommand)]
enum Commands {
/// Runs the server
Server,
/// Generates and persists a keypair to use for PAKE registration and login
Keygen {
#[clap(short, long)]
#[clap(default_value_t = String::from(DEFAULT_SECRETS_DIRECTORY))]
dir: String,
},
}
#[tokio::main] #[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> { async fn main() -> Result<(), Box<dyn std::error::Error>> {
let cli = Cli::parse();
match &cli.command {
Commands::Keygen { dir } => {
generate_and_persist_keypair(dir)?;
}
Commands::Server => {
let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?; let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;
let identity_service = MyIdentityService::default(); let identity_service = MyIdentityService::default();
Server::builder() Server::builder()
.add_service(IdentityServiceServer::new(identity_service)) .add_service(IdentityServiceServer::new(identity_service))
.serve(addr) .serve(addr)
.await?; .await?;
}
}
Ok(()) Ok(())
} }
View Options

keyserver/src/socket/socket.js

use clap::{Parser, Subcommand};
use tonic::transport::Server; use tonic::transport::Server;
mod keygen;
mod opaque;
mod service; mod service;
use keygen::generate_and_persist_keypair;
use service::{IdentityServiceServer, MyIdentityService}; use service::{IdentityServiceServer, MyIdentityService};
const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051"; const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051";
const DEFAULT_SECRETS_DIRECTORY: &str = "secrets";
#[derive(Parser)]
#[clap(author, version, about, long_about = None)]
#[clap(propagate_version = true)]
struct Cli {
#[clap(subcommand)]
command: Commands,
}
#[derive(Subcommand)]
enum Commands {
/// Runs the server
Server,
/// Generates and persists a keypair to use for PAKE registration and login
Keygen {
#[clap(short, long)]
#[clap(default_value_t = String::from(DEFAULT_SECRETS_DIRECTORY))]
dir: String,
},
}
#[tokio::main] #[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> { async fn main() -> Result<(), Box<dyn std::error::Error>> {
let cli = Cli::parse();
match &cli.command {
Commands::Keygen { dir } => {
generate_and_persist_keypair(dir)?;
}
Commands::Server => {
let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?; let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;
let identity_service = MyIdentityService::default(); let identity_service = MyIdentityService::default();
Server::builder() Server::builder()
.add_service(IdentityServiceServer::new(identity_service)) .add_service(IdentityServiceServer::new(identity_service))
.serve(addr) .serve(addr)
.await?; .await?;
}
}
Ok(()) Ok(())
} }