Page MenuHomePhabricator
Differential D9558

[web] Create new chat button creates chat in GENESIS community only
ClosedPublic
Actions

Authored by will on Oct 20 2023, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:23 AM
Unknown Object (File)
Thu, Nov 14, 11:00 AM
Unknown Object (File)
Sun, Nov 10, 8:18 PM
Unknown Object (File)
Fri, Nov 8, 9:48 AM
View All 89 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMMb89f55c87e69: [web] Create new chat button creates chat in GENESIS community only
Summary

Changed create chat button when in non-GENESIS community to begin create channel experience.
Created onClickSubchannel which pushes ComposeSubchannelModal when communityID does not equal genesis.id.
Added conditional to change "Create new chat" to "Create new channel" when in non-GENESIS community.

Test Plan

Verified working on local web version and ran flow.

Diff Detail

Repository
rCOMM Comm
Branch
wyilio/create_chat
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Oct 20 2023, 1:24 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 20 2023, 1:24 PM
will retitled this revision from [native] Create new chat button creates chat in GENESIS community only to [web] Create new chat button creates chat in GENESIS community only.Oct 20 2023, 1:25 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2023, 1:26 PM
Harbormaster failed remote builds in B23412: Diff 32293!
will edited the summary of this revision. (Show Details)Oct 20 2023, 1:26 PM
will updated this revision to Diff 32294.Oct 20 2023, 1:35 PM

update to master to fix commTest error

Harbormaster completed remote builds in B23413: Diff 32294.Oct 20 2023, 1:54 PM
will requested review of this revision.Oct 20 2023, 1:54 PM
ashoat accepted this revision.Oct 22 2023, 4:02 PM
ashoat added inline comments.
web/chat/chat-thread-list.react.js
153–172 ↗(On Diff #32294)

I think it would be more readable to extract these

This revision is now accepted and ready to land.Oct 22 2023, 4:02 PM
will updated this revision to Diff 32317.Oct 23 2023, 10:30 AM

Extract onClick and button text for readability

This revision was landed with ongoing or failed builds.Oct 23 2023, 10:34 AM
Closed by commit rCOMMb89f55c87e69: [web] Create new chat button creates chat in GENESIS community only (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMb89f55c87e69: [web] Create new chat button creates chat in GENESIS community only.
Harbormaster failed remote builds in B23426: Diff 32317!Oct 23 2023, 10:41 AM
will added a reverting change: rCOMM5ddc92900713: Revert "[web] Create new chat button creates chat in GENESIS community only".Oct 23 2023, 11:22 AM

Revision Contents
Changeset List

PathSize
web/
chat/
35 lines

Diff 32293

View Options

web/chat/chat-thread-list.react.js

Loading...