Page MenuHomePhabricator

[web] Create new chat button creates chat in GENESIS community only
ClosedPublic

Authored by will on Oct 20 2023, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 2:44 AM
Unknown Object (File)
Mon, Nov 25, 2:28 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:23 AM
Unknown Object (File)
Thu, Nov 14, 11:00 AM
Subscribers

Details

Summary

Changed create chat button when in non-GENESIS community to begin create channel experience.
Created onClickSubchannel which pushes ComposeSubchannelModal when communityID does not equal genesis.id.
Added conditional to change "Create new chat" to "Create new channel" when in non-GENESIS community.

Test Plan

Verified working on local web version and ran flow.

Diff Detail

Repository
rCOMM Comm
Branch
wyilio/create_chat
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will retitled this revision from [native] Create new chat button creates chat in GENESIS community only to [web] Create new chat button creates chat in GENESIS community only.Oct 20 2023, 1:25 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2023, 1:26 PM
Harbormaster failed remote builds in B23412: Diff 32293!

update to master to fix commTest error

will requested review of this revision.Oct 20 2023, 1:54 PM
ashoat added inline comments.
web/chat/chat-thread-list.react.js
153–172 ↗(On Diff #32294)

I think it would be more readable to extract these

This revision is now accepted and ready to land.Oct 22 2023, 4:02 PM

Extract onClick and button text for readability

This revision was landed with ongoing or failed builds.Oct 23 2023, 10:34 AM
This revision was automatically updated to reflect the committed changes.