[scripts] remove cargo-lipo from rustup setup
ClosedPublic
Actions

Authored by varun on Oct 30 2023, 9:55 AM.

Tags

None

Referenced Files

	F2899004: D9635.diff
	Sat, Oct 5, 4:49 AM

	Unknown Object (File)
	Thu, Oct 3, 10:46 PM

	Unknown Object (File)
	Wed, Oct 2, 2:22 PM

	Unknown Object (File)
	Fri, Sep 13, 3:56 PM

	Unknown Object (File)
	Fri, Sep 13, 3:56 PM

	Unknown Object (File)
	Fri, Sep 13, 3:55 PM

	Unknown Object (File)
	Fri, Sep 13, 3:49 PM

	Unknown Object (File)
	Mon, Sep 9, 2:21 PM

View All 39 Files

Subscribers

tomek

will

Details

Reviewers

ashoat

Commits

rCOMM303a00eedd94: [scripts] remove cargo-lipo from rustup setup

Summary

we don't need this anymore since we're building a target-specific native_rust_library now

Test Plan

uninstalled cargo-lipo and successfully built the iOS app. confirmed that cargo-lipo still wasn't installed on my machine after build

Diff Detail

Repository

rCOMM Comm

Branch

new-master-2 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Oct 30 2023, 9:55 AM

Herald added subscribers: will, tomek. · View Herald TranscriptOct 30 2023, 9:55 AM

Harbormaster completed remote builds in B23574: Diff 32504.Oct 30 2023, 10:36 AM

varun requested review of this revision.Oct 30 2023, 10:36 AM

ashoat accepted this revision.Oct 30 2023, 11:30 AM

This revision is now accepted and ready to land.Oct 30 2023, 11:30 AM

Closed by commit rCOMM303a00eedd94: [scripts] remove cargo-lipo from rustup setup (authored by varun). · Explain WhyOct 30 2023, 2:32 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM303a00eedd94: [scripts] remove cargo-lipo from rustup setup.

Revision Contents
Changeset List

Path

Size

scripts/

ensure_rustup_setup.sh

4 lines

Diff 32504

View Options

scripts/ensure_rustup_setup.sh

[scripts] remove cargo-lipo from rustup setupClosedPublicActions