I don't love the naming here. The issue starts with the proto file names... "client" vs. "authenticated" isn't a clear dichotomy. The use of "client" in this file makes more sense, but adds further confusion.

This revision is now accepted and ready to land.Nov 9 2023, 4:17 AM

In D9793#286073, @ashoat wrote:

I don't love the naming here. The issue starts with the proto file names... "client" vs. "authenticated" isn't a clear dichotomy. The use of "client" in this file makes more sense, but adds further confusion.

i don't like the naming either. i'd prefer something like identity_unauthenticated.proto and identity_authenticated.proto. https://linear.app/comm/issue/ENG-5690/rename-proto-files-to-something-more-intuitive

varun added a child revision: D9807: [web] add generated js code and flow types for identity_authenticated.proto.Nov 9 2023, 12:24 PM

Closed by commit rCOMM56d1d0833dde: [web] modify codegen script to generate files for identity_authenticated.proto (authored by varun). · Explain WhyNov 9 2023, 12:25 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM56d1d0833dde: [web] modify codegen script to generate files for identity_authenticated.proto.