Page MenuHomePhabricator

[keyserver] Use getUniversalCommunityRootPermissionsBlob in role-creator
AbandonedPublic

Authored by rohan on Wed, Nov 15, 12:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 1, 10:41 AM
Unknown Object (File)
Thu, Nov 30, 4:01 PM
Unknown Object (File)
Tue, Nov 28, 3:39 PM
Unknown Object (File)
Mon, Nov 27, 7:40 AM
Unknown Object (File)
Wed, Nov 22, 2:01 AM
Unknown Object (File)
Wed, Nov 15, 3:39 PM
Subscribers

Details

Reviewers
atul
ginsu
ashoat
Summary

To get rid of the hack of having to push threadPermissions.VOICED for COMMUNITY_ROOT threads, we now can just source the universal community permissions from getUniversalCommunityRootPermissionsBlob, which will automatically include voiced for that thread type.

Going to add community validation in the next diff so we can make sure a role is created only for community roots.

Test Plan

Went through the community creation + role creation process to make sure things were still working as expected. Also made sure to check that new roles automatically have voiced in COMMUNITY_ROOT but not COMMUNITY_ANNOUNCEMENT_ROOT

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan published this revision for review.Wed, Nov 15, 12:26 PM
This revision is now accepted and ready to land.Wed, Nov 15, 12:43 PM

This is getting merged into D9897