Page MenuHomePhabricator

[keyserver] Use getUniversalCommunityRootPermissionsBlob in role-creator
AbandonedPublic

Authored by rohan on Nov 15 2023, 12:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 1, 1:23 PM
Unknown Object (File)
Sun, Jun 30, 6:42 PM
Unknown Object (File)
Mon, Jun 24, 2:03 PM
Unknown Object (File)
Fri, Jun 21, 1:43 PM
Unknown Object (File)
Thu, Jun 13, 7:00 PM
Unknown Object (File)
Wed, Jun 12, 9:24 AM
Unknown Object (File)
May 25 2024, 3:05 PM
Unknown Object (File)
May 7 2024, 12:35 PM
Subscribers

Details

Reviewers
atul
ginsu
ashoat
Summary

To get rid of the hack of having to push threadPermissions.VOICED for COMMUNITY_ROOT threads, we now can just source the universal community permissions from getUniversalCommunityRootPermissionsBlob, which will automatically include voiced for that thread type.

Going to add community validation in the next diff so we can make sure a role is created only for community roots.

Test Plan

Went through the community creation + role creation process to make sure things were still working as expected. Also made sure to check that new roles automatically have voiced in COMMUNITY_ROOT but not COMMUNITY_ANNOUNCEMENT_ROOT

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan published this revision for review.Nov 15 2023, 12:26 PM
This revision is now accepted and ready to land.Nov 15 2023, 12:43 PM

This is getting merged into D9897