Paths

Table of Contentst

[lib] Update all-but-one instance of `RelativeMemberInfo` with `RelativeMemberInfo|MinimallyEncodedRelativeMemberInfo`
ClosedPublic
Actions

Authored by atul on Fri, Nov 17, 6:19 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM320f2a62064a: [lib] Update all-but-one instance of `RelativeMemberInfo` with…

Summary

Replace almost all instances of RelativeMemberInfo with RelativeMemberInfo | MinimallyEncodedRelativeMemberInfo.

We still need to update getRelativeMember, but breaking that into a separate diff since that's more than just updating signature.

Test Plan

Trusting flow.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Fri, Nov 17, 6:19 PM

Harbormaster completed remote builds in B24258: Diff 33396.Fri, Nov 17, 6:38 PM

atul requested review of this revision.Fri, Nov 17, 6:38 PM

ashoat accepted this revision.Sun, Nov 19, 11:33 AM

This revision is now accepted and ready to land.Sun, Nov 19, 11:33 AM

rebase and land

Harbormaster completed remote builds in B24287: Diff 33437.Mon, Nov 20, 10:29 AM

land

This revision was landed with ongoing or failed builds.Mon, Nov 20, 10:52 AM

Closed by commit rCOMM320f2a62064a: [lib] Update all-but-one instance of `RelativeMemberInfo` with… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM320f2a62064a: [lib] Update all-but-one instance of `RelativeMemberInfo` with….

Harbormaster completed remote builds in B24288: Diff 33438.Mon, Nov 20, 11:10 AM

Revision Contents
Changeset List

Path

Size

lib/

selectors/

thread-selectors.js

9 lines

user-selectors.js

8 lines

shared/

thread-utils.js

2 lines

web/

modals/

threads/

members/

change-member-role-modal.react.js

7 lines

member.react.js

7 lines

members-list.react.js

29 lines

members-modal.react.js

8 lines

Diff 33439

View Options

lib/selectors/thread-selectors.js

View Options

lib/selectors/user-selectors.js

View Options

lib/shared/thread-utils.js

View Options

web/modals/threads/members/change-member-role-modal.react.js

View Options

web/modals/threads/members/member.react.js

View Options

web/modals/threads/members/members-list.react.js

View Options

web/modals/threads/members/members-modal.react.js

[lib] Update all-but-one instance of `RelativeMemberInfo` with `RelativeMemberInfo|MinimallyEncodedRelativeMemberInfo`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33439

lib/selectors/thread-selectors.js

lib/selectors/user-selectors.js

lib/shared/thread-utils.js

web/modals/threads/members/change-member-role-modal.react.js

web/modals/threads/members/member.react.js

web/modals/threads/members/members-list.react.js

web/modals/threads/members/members-modal.react.js

[lib] Update all-but-one instance of `RelativeMemberInfo` with `RelativeMemberInfo|MinimallyEncodedRelativeMemberInfo`
ClosedPublic
Actions

Revision Contents
Changeset List