Paths

Table of Contentst

Differential D3352

[native] Make MessageList able to fetch messages if none are present
ClosedPublic
Actions

Authored by ashoat on Mar 6 2022, 4:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Nov 17 2024, 2:04 PM

	Unknown Object (File)
	Nov 6 2024, 11:36 AM

	Unknown Object (File)
	Nov 2 2024, 8:32 AM

	Unknown Object (File)
	Oct 26 2024, 8:18 AM

	Unknown Object (File)
	Oct 26 2024, 8:17 AM

	Unknown Object (File)
	Oct 26 2024, 8:17 AM

	Unknown Object (File)
	Oct 15 2024, 7:57 AM

	Unknown Object (File)
	Oct 12 2024, 7:03 AM

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMMb24bedc0e4bf: [native] Make MessageList able to fetch messages if none are present

Summary

With the changes in the earlier diff, we may end up with zero messages for a given thread. This diff makes it possible for us to fetch messages in that case.

Depends On D3351

Test Plan

I decreased defaultMaxMessageAge such that no messages got loaded at all, and made sure that when I opened a thread without messages, the messages were fetche
d

Diff Detail

Repository

Branch

ashoat/website_load

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 6 2022, 4:18 PM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 6 2022, 4:18 PM

ashoat added a child revision: D3353: [lib] Show loader when there are no messages.Mar 6 2022, 4:20 PM

Harbormaster completed remote builds in B7172: Diff 10098.Mar 6 2022, 4:23 PM

ashoat requested review of this revision.Mar 6 2022, 4:23 PM

ashoat mentioned this in D3354: [server] Gate global time filter for message queries on codeVersion.Mar 6 2022, 10:16 PM

ashoat mentioned this in D3349: [server] Always filter message queries by message creation time.Mar 6 2022, 10:16 PM

tomek accepted this revision.Mar 8 2022, 6:50 AM

This revision is now accepted and ready to land.Mar 8 2022, 6:50 AM

Herald added a subscriber: • benschac. · View Herald TranscriptMar 8 2022, 6:50 AM

Rebase

Harbormaster completed remote builds in B7218: Diff 10148.Mar 8 2022, 8:10 AM

Closed by commit rCOMMb24bedc0e4bf: [native] Make MessageList able to fetch messages if none are present (authored by ashoat). · Explain WhyMar 8 2022, 8:33 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb24bedc0e4bf: [native] Make MessageList able to fetch messages if none are present.

ashoat mentioned this in rCOMM00e559c14bef: [server] Gate global time filter for message queries on codeVersion.

ashoat mentioned this in D3411: [server] Don't unset TRUNCATED if threadCursor is null.Mar 11 2022, 11:39 AM

ashoat mentioned this in rCOMM362a843ed259: [server] Don't unset TRUNCATED if threadCursor is null.Mar 14 2022, 12:47 PM

Revision Contents
Changeset List

Path

Size

native/

chat/

message-list.react.js

9 lines

Diff 10098

native/chat/message-list.react.js

Loading...