Page MenuHomePhabricator
Differential D3307

[web] Properly style `messageActionButtonsContainer`
ClosedPublic
Actions

Authored by atul on Feb 28 2022, 3:10 PM.
Tags
None
Referenced Files
F3300868: D3307.diff
Sun, Nov 17, 10:23 PM
Unknown Object (File)
Sat, Nov 2, 8:42 AM
Unknown Object (File)
Sat, Nov 2, 8:42 AM
Unknown Object (File)
Sat, Nov 2, 8:42 AM
Unknown Object (File)
Sat, Nov 2, 8:42 AM
Unknown Object (File)
Sat, Nov 2, 8:42 AM
Unknown Object (File)
Sat, Nov 2, 8:41 AM
Unknown Object (File)
Oct 6 2024, 9:11 AM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
tomek
• jacek
• benschac
varun
Commits
rCOMM94b1328fcf9a: [web] Properly style `messageActionButtonsContainer`
Summary

Before: https://blob.sh/atul/b611.png
After: https://blob.sh/atul/1349.png

Test Plan

NA

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 28 2022, 3:10 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptFeb 28 2022, 3:10 PM
Harbormaster completed remote builds in B7074: Diff 9965.Feb 28 2022, 3:23 PM
atul requested review of this revision.Feb 28 2022, 3:23 PM
tomek requested changes to this revision.Mar 1 2022, 3:21 AM
tomek added inline comments.
web/chat/message-action-buttons.css
7 ↗(On Diff #9965)

Interesting! But are you sure that this property is supported by the browsers we support / are the polyfills added for it? I guess it would help if we had somewhere defined a list of all the supported platforms somewhere.

This revision now requires changes to proceed.Mar 1 2022, 3:21 AM
atul updated this revision to Diff 10107.Mar 7 2022, 7:02 AM

avoid margin-inline since it's new

atul marked an inline comment as done.Mar 7 2022, 7:02 AM
atul added inline comments.
web/chat/message-action-buttons.css
7 ↗(On Diff #9965)

Ah, you're right it does look like this property is relatively recent.

But are you sure that this property is supported by the browsers we support / are the polyfills added for it?

I'm not sure, I'll just change this to use "older" properties for now to unblock this diff and take a look later in the day.

Harbormaster completed remote builds in B7181: Diff 10107.Mar 7 2022, 7:08 AM
tomek accepted this revision.Mar 8 2022, 7:10 AM
tomek added inline comments.
web/chat/message-action-buttons.css
7–8

We can use a shorthand

This revision is now accepted and ready to land.Mar 8 2022, 7:10 AM
atul updated this revision to Diff 10170.Mar 8 2022, 10:18 AM
atul marked an inline comment as done.

address feedback

This revision was landed with ongoing or failed builds.Mar 8 2022, 10:20 AM
Closed by commit rCOMM94b1328fcf9a: [web] Properly style `messageActionButtonsContainer` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM94b1328fcf9a: [web] Properly style `messageActionButtonsContainer`.
Harbormaster completed remote builds in B7227: Diff 10170.Mar 8 2022, 10:24 AM

Revision Contents
Changeset List

Diff 10107

View Options

web/chat/message-action-buttons.css

Loading...
View Options

web/chat/message-action-buttons.js

Loading...