[web] Fix sidebar hover styling in `ChatThreadListSidebar`
ClosedPublic
Actions

Authored by atul on Mar 7 2022, 5:30 PM.

Details

Reviewers

tomek
• jacek
• benschac
varun

Commits

rCOMMc94bd22e8286: [web] Fix sidebar hover styling in `ChatThreadListSidebar`

Summary

Sidebars in the thread list were not being highlighted on hover.. figured they should be.

Test Plan

Before:

After:

Diff Detail

Repository

rCOMM Comm

Branch

feb24 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 7 2022, 5:30 PM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 7 2022, 5:30 PM

Harbormaster completed remote builds in B7195: Diff 10124.Mar 7 2022, 5:35 PM

atul requested review of this revision.Mar 7 2022, 5:35 PM

This diff doesn't have any screenshot or test plan. It's trivial to test, but I think that having a screenshot to make sure it looks ok would be a good idea

web/chat/chat-thread-list.css
28	I know it was introduced previously, but it should be threadListSidebar

This revision is now accepted and ready to land.Mar 8 2022, 8:13 AM

We should almost never see "NA" in a test plan. The shortest test plan you should have is "Flow". Otherwise we should see a screenshot or some plan to test the changes

We should almost never see "NA" in a test plan. The shortest test plan you should have is "Flow". Otherwise we should see a screenshot or some plan to test the changes

Ah yeah my bad. I think I intended to include the screenshot in the summary (on Phabricator via drag-and-drop instead of link) based on the ellipsis at the end of the summary.

I'll update the Test Plan with the screenshot instead before landing.

atul edited the summary of this revision. (Show Details)Mar 8 2022, 11:49 AM

atul edited the test plan for this revision. (Show Details)

atul marked an inline comment as done.

atul added inline comments.