Page MenuHomePhabricator
Differential D3354

[server] Gate global time filter for message queries on codeVersion
ClosedPublic
Actions

Authored by ashoat on Mar 6 2022, 10:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 7:24 AM
Unknown Object (File)
Nov 17 2024, 1:55 PM
Unknown Object (File)
Nov 17 2024, 1:39 PM
Unknown Object (File)
Nov 17 2024, 12:51 PM
Unknown Object (File)
Nov 17 2024, 12:34 PM
Unknown Object (File)
Nov 17 2024, 10:58 AM
Unknown Object (File)
Nov 8 2024, 10:38 PM
Unknown Object (File)
Nov 8 2024, 10:38 PM
View All Files
Subscribers
• adrian
• benschac
• karol

Details

Reviewers
tomek
atul
Commits
rCOMM00e559c14bef: [server] Gate global time filter for message queries on codeVersion
Summary

After realizing native needs D3350, D3352, and D3353 in order to work properly with the server changes in D3349, I concluded I should be gating the changes on codeVersion.

Depends on D3353

Test Plan

I played around with the gating codeVersion with a simulator to made sure it works as expected for old versions and for new versions

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 6 2022, 10:16 PM
Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 6 2022, 10:16 PM
ashoat mentioned this in D3349: [server] Always filter message queries by message creation time.Mar 6 2022, 10:16 PM
ashoat updated this revision to Diff 10101.Mar 6 2022, 10:17 PM

Minor

Harbormaster completed remote builds in B7174: Diff 10100.Mar 6 2022, 10:21 PM
Harbormaster completed remote builds in B7175: Diff 10101.Mar 6 2022, 10:24 PM
ashoat requested review of this revision.Mar 6 2022, 10:24 PM
tomek accepted this revision.Mar 8 2022, 6:52 AM
This revision is now accepted and ready to land.Mar 8 2022, 6:52 AM
Herald added a subscriber: • benschac. · View Herald TranscriptMar 8 2022, 6:52 AM
ashoat updated this revision to Diff 10150.Mar 8 2022, 7:47 AM

Set codeVersion for applying time filter to 130 (next version), and also rebase

ashoat added a comment.Mar 8 2022, 8:06 AM

Tested this and it works!

ashoat edited the test plan for this revision. (Show Details)Mar 8 2022, 8:06 AM
Harbormaster completed remote builds in B7220: Diff 10150.Mar 8 2022, 8:18 AM
Closed by commit rCOMM00e559c14bef: [server] Gate global time filter for message queries on codeVersion (authored by ashoat). · Explain WhyMar 8 2022, 8:33 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM00e559c14bef: [server] Gate global time filter for message queries on codeVersion.

Revision Contents
Changeset List

PathSize
server/
src/
fetchers/
15 lines

Diff 10150

View Options

server/src/fetchers/message-fetchers.js

Loading...