Page MenuHomePhabricator
Differential D3350

[lib] Don't assume freshMessageStore always has messages for a thread
ClosedPublic
Actions

Authored by ashoat on Mar 6 2022, 3:45 PM.
Tags
None
Referenced Files
F3504499: D3350.id10095.diff
Fri, Dec 20, 9:15 AM
F3501850: D3350.diff
Fri, Dec 20, 3:50 AM
Unknown Object (File)
Mon, Nov 25, 2:37 PM
Unknown Object (File)
Mon, Nov 25, 1:49 PM
Unknown Object (File)
Nov 6 2024, 11:36 AM
Unknown Object (File)
Nov 2 2024, 8:31 AM
Unknown Object (File)
Nov 2 2024, 3:02 AM
Unknown Object (File)
Oct 27 2024, 12:58 AM
View All Files
Subscribers
• adrian
• benschac
• karol

Details

Reviewers
tomek
atul
Commits
rCOMM61db92aabe75: [lib] Don't assume freshMessageStore always has messages for a thread
Summary

Given the changes in the previous diff, we can no longer assume that if a thread has messages, at least one of those messages will be present in a fresh MessageStore.

There should be no threads with zero messages anyways, so this change should be safe. In the worst case, if we have some database corruption and threads exist with zero messages, this diff will force a server call to try and fetch the messages. After the server call returns, startReached should be correctly flipped to true.

Depends On D3349

Test Plan

I decreased defaultMaxMessageAge such that no messages got loaded at all, and made sure that when I opened a thread without messages, the messages were fetched

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 6 2022, 3:45 PM
Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 6 2022, 3:45 PM
ashoat mentioned this in D3351: [web] Make ChatMessageList able to fetch messages if none are present.Mar 6 2022, 3:46 PM
ashoat added a child revision: D3351: [web] Make ChatMessageList able to fetch messages if none are present.Mar 6 2022, 3:47 PM
ashoat edited the summary of this revision. (Show Details)
ashoat added a parent revision: D3349: [server] Always filter message queries by message creation time.
Harbormaster completed remote builds in B7169: Diff 10095.Mar 6 2022, 3:59 PM
ashoat requested review of this revision.Mar 6 2022, 3:59 PM
ashoat mentioned this in D3354: [server] Gate global time filter for message queries on codeVersion.Mar 6 2022, 10:16 PM
ashoat mentioned this in D3349: [server] Always filter message queries by message creation time.Mar 6 2022, 10:16 PM
atul accepted this revision.Mar 7 2022, 10:19 PM
This revision is now accepted and ready to land.Mar 7 2022, 10:19 PM
Herald added a subscriber: • benschac. · View Herald TranscriptMar 7 2022, 10:19 PM
ashoat updated this revision to Diff 10146.Mar 8 2022, 7:45 AM

Rebase

Harbormaster completed remote builds in B7216: Diff 10146.Mar 8 2022, 8:01 AM
Closed by commit rCOMM61db92aabe75: [lib] Don't assume freshMessageStore always has messages for a thread (authored by ashoat). · Explain WhyMar 8 2022, 8:32 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM61db92aabe75: [lib] Don't assume freshMessageStore always has messages for a thread.
ashoat mentioned this in rCOMM00e559c14bef: [server] Gate global time filter for message queries on codeVersion.
ashoat mentioned this in D5492: [lib] Always initialize messageStore.messages with startReached: false.Oct 27 2022, 7:05 AM

Revision Contents
Changeset List

PathSize
lib/
reducers/
3 lines

Diff 10154

View Options

lib/reducers/message-reducer.js

Loading...