Paths

Table of Contentst

Differential D3353

[lib] Show loader when there are no messages
ClosedPublic
Actions

Authored by ashoat on Mar 6 2022, 4:20 PM.

Tags

None

Referenced Files

	F3530430: D3353.id10099.diff
	Wed, Dec 25, 2:42 AM

	F3530414: D3353.id10149.diff
	Wed, Dec 25, 2:27 AM

	F3529115: D3353.diff
	Tue, Dec 24, 3:11 PM

	Unknown Object (File)
	Wed, Dec 18, 7:03 PM

	Unknown Object (File)
	Wed, Dec 18, 7:03 PM

	Unknown Object (File)
	Mon, Dec 9, 12:56 AM

	Unknown Object (File)
	Nov 21 2024, 5:46 PM

	Unknown Object (File)
	Nov 2 2024, 8:32 AM

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMMc3135d9be421: [lib] Show loader when there are no messages

Summary

Earlier changes in this stack made it possible for a thread to appear without any messages. Without this change, the loader doesn't appear when there aren't messages, which means that MessageList in native never triggers a message fetch.

Depends On D3352

Test Plan

I decreased defaultMaxMessageAge such that no messages got loaded at all, and made sure that when I opened a thread without messages, the messages were fetche
d

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 6 2022, 4:20 PM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 6 2022, 4:20 PM

Harbormaster completed remote builds in B7173: Diff 10099.Mar 6 2022, 4:26 PM

ashoat requested review of this revision.Mar 6 2022, 4:26 PM

ashoat added a child revision: D3354: [server] Gate global time filter for message queries on codeVersion.Mar 6 2022, 10:16 PM

ashoat mentioned this in D3349: [server] Always filter message queries by message creation time.Mar 6 2022, 10:16 PM

atul accepted this revision.Mar 7 2022, 10:19 PM

This revision is now accepted and ready to land.Mar 7 2022, 10:19 PM

Herald added a subscriber: • benschac. · View Herald TranscriptMar 7 2022, 10:19 PM

Rebase

Harbormaster completed remote builds in B7219: Diff 10149.Mar 8 2022, 8:14 AM

Closed by commit rCOMMc3135d9be421: [lib] Show loader when there are no messages (authored by ashoat). · Explain WhyMar 8 2022, 8:33 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc3135d9be421: [lib] Show loader when there are no messages.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

3 lines

Diff 10157

lib/selectors/chat-selectors.js

Loading...