Paths

Table of Contentst

Differential D3371

[web] Make all `<a>` and `<button>` `cursor:pointer`
ClosedPublic
Actions

Authored by atul on Mar 8 2022, 2:13 PM.

Tags

None

Referenced Files

	F3391927: D3371.id10183.diff
	Sat, Nov 30, 6:36 AM

	F3391893: D3371.id10224.diff
	Sat, Nov 30, 6:29 AM

	Unknown Object (File)
	Wed, Nov 27, 2:43 AM

	Unknown Object (File)
	Mon, Nov 25, 1:23 AM

	Unknown Object (File)
	Wed, Nov 20, 12:45 AM

	Unknown Object (File)
	Tue, Nov 19, 4:57 AM

	Unknown Object (File)
	Thu, Nov 14, 8:51 AM

	Unknown Object (File)
	Sat, Nov 9, 5:50 PM

Subscribers

Details

Reviewers

tomek
• jacek
varun
• benschac

Commits

rCOMMc2e121f34882: [web] Make all `<a>` and `<button>` `cursor:pointer`

Summary

This came up in D3364 when we manually added cursor:pointer to a.sendButton.

Followed @palys-swm suggestion (https://phabricator.ashoat.com/D3364#90810) and applied this style "globally."

Note: I am not planning on going through the codebase right now and cutting every extraneous cursor:pointer applied to an <a> or <button>. I think doing so would be fine, but I don't want to check every single instance right now to ensure that there are no regressions. I think it's fine to leave them in even if they may be redundant.

Test Plan

Patch this diff.
Revert change in D3364 (comment out line manually)
Make sure that we see a pointer when we hover over sendbutton
Revert this diff
Make sure that we don't see a pointer when we hover over sendbutton

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 8 2022, 2:13 PM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 8 2022, 2:13 PM

atul mentioned this in D3364: [web] Set `cursor: pointer` for `sendButton`.Mar 8 2022, 2:13 PM

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B7230: Diff 10183.Mar 8 2022, 2:18 PM

atul requested review of this revision.Mar 8 2022, 2:18 PM

• benschac accepted this revision.Mar 8 2022, 2:29 PM

This revision is now accepted and ready to land.Mar 8 2022, 2:29 PM

Should we create a diff where we remove cursor: pointer from all the other places?

In D3371#91115, @palys-swm wrote:

Should we create a diff where we remove cursor: pointer from all the other places?

Ah, you've explained this in the note. That makes sense!

Closed by commit rCOMMc2e121f34882: [web] Make all `<a>` and `<button>` `cursor:pointer` (authored by atul). · Explain WhyMar 9 2022, 8:22 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMc2e121f34882: [web] Make all `<a>` and `<button>` `cursor:pointer`.

Revision Contents
Changeset List

Path

Size

web/

4 lines

Diff 10224

web/style.css

Loading...