Here's what it looks like:
Details
Details
Looks as expected
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
It doesn't seem like this is present on the designs https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77277 but I like this idea.
| web/chat/message-action-buttons.css | ||
|---|---|---|
| 5–10 ↗ | (On Diff #10119) | I don't think that changing opacity is the best solution. In this case it might work correct, but what if tooltip background had more colors? (unlikely) A better approach would be to change just color. By doing that the buttons would look ok even when background is not solid and when we decide to change the background solid color. |
Comment Actions
A bigger issue is that the color of buttons now depends on the background color, so we can't simply change background colors without changing the buttons.
Ah good point, using opacity doesn't seem like a robust solution.
I'll update this diff to use var(--color-disabled) and var(--fg) instead to match what we're doing elsewhere.