Differential D3423

[native] Remove unnecessary `invariant` in `ImagePasteModal:sendImage`
ClosedPublic
Actions

Authored by atul on Mar 14 2022, 10:46 AM.

Tags

None

Referenced Files

	F3757900: D3423.id10352.diff
	Fri, Jan 10, 7:44 AM

	F3755462: D3423.diff
	Fri, Jan 10, 4:45 AM

	Unknown Object (File)
	Sun, Jan 5, 2:15 PM

	Unknown Object (File)
	Sun, Jan 5, 2:15 PM

	Unknown Object (File)
	Sun, Jan 5, 2:14 PM

	Unknown Object (File)
	Sun, Jan 5, 2:09 PM

	Unknown Object (File)
	Nov 17 2024, 6:25 AM

	Unknown Object (File)
	Nov 16 2024, 10:07 AM

Subscribers

Details

Reviewers

tomek
• jacek
• benschac
varun
ashoat

Commits

rCOMMc1fc63d302a3: [native] Remove unnecessary `invariant` in `ImagePasteModal:sendImage`

Summary

I can't see any reason we have an invariant at the end of the callback here. Looks like this was introduced in one of my first diffs (https://phabricator.ashoat.com/D639) and I probably didn't really understand what was happening with flow/invariants

Test Plan

Flow

Diff Detail

Repository

Branch

landmarch14 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 14 2022, 10:46 AM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 14 2022, 10:46 AM

Harbormaster completed remote builds in B7351: Diff 10352.Mar 14 2022, 10:52 AM

atul requested review of this revision.Mar 14 2022, 10:52 AM

atul added a reviewer: ashoat.Mar 15 2022, 8:17 AM

tomek accepted this revision.Mar 15 2022, 11:29 AM

This revision is now accepted and ready to land.Mar 15 2022, 11:29 AM

Closed by commit rCOMMc1fc63d302a3: [native] Remove unnecessary `invariant` in `ImagePasteModal:sendImage` (authored by atul). · Explain WhyMar 15 2022, 1:20 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMc1fc63d302a3: [native] Remove unnecessary `invariant` in `ImagePasteModal:sendImage`.

Revision Contents
Changeset List

Path

Size

native/

chat/

image-paste-modal.react.js

4 lines

Diff 10352

native/chat/image-paste-modal.react.js

Loading...